Add server.address and server.port for lettuce #15257
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
reviewed
Nov 11, 2025
| RedisURI redisUri = LettuceSingletons.CONNECTION_URI.get(connection); | ||
|
|
||
| if (redisUri != null) { | ||
| COMMAND_CONNECTION_INFO.set(command, redisUri); |
Contributor
There was a problem hiding this comment.
Perhaps it would be better to introduce LettuceRequest class that could contain both the command and the uri.
laurit
reviewed
Nov 11, 2025
| @Advice.This AbstractRedisAsyncCommands<?, ?> asyncCommands, | ||
| @Advice.Argument(0) RedisCommand<?, ?, ?> command) { | ||
|
|
||
| StatefulConnection<?, ?> connection = asyncCommands.getConnection(); |
Contributor
There was a problem hiding this comment.
Lettuce also has support for redis clusters. I suspect that this code will not correctly work on clusters. Have you verified how it would behave for clusters? Perhaps we need to add a tests for the RedisClusterClient and verify that we don't fill the server.address incorrectly there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.