Consolidate network attribute extraction into DbClientAttributesGetter #15149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 tasks
github-actions
bot
added
the
test native
trask
force-pushed
the
db-networking-attributes
branch
3 times, most recently
from
d2988b1 to
a6bef40
Compare
trask
commented
Oct 27, 2025
...ava/io/opentelemetry/javaagent/instrumentation/vertx/sql/VertxSqlClientAttributesGetter.java
Show resolved
Hide resolved
...main/java/io/opentelemetry/instrumentation/r2dbc/v1_0/internal/R2dbcInstrumenterBuilder.java
Outdated
Show resolved
Hide resolved
.../javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/jdbc/JdbcSingletons.java
Outdated
Show resolved
Hide resolved
trask
commented
Oct 28, 2025
.../io/opentelemetry/javaagent/instrumentation/cassandra/v3_0/CassandraSqlAttributesGetter.java
Outdated
Show resolved
Hide resolved
.../io/opentelemetry/javaagent/instrumentation/cassandra/v4_0/CassandraSqlAttributesGetter.java
Outdated
Show resolved
Hide resolved
.../main/java/io/opentelemetry/instrumentation/cassandra/v4_4/CassandraSqlAttributesGetter.java
Outdated
Show resolved
Hide resolved
trask
force-pushed
the
db-networking-attributes
branch
2 times, most recently
from
2cb64a7 to
898e9a2
Compare
trask
force-pushed
the
db-networking-attributes
branch
from
898e9a2 to
d926221
Compare
trask
commented
Nov 13, 2025
...java/io/opentelemetry/instrumentation/api/incubator/semconv/db/DbClientAttributesGetter.java
Outdated
Show resolved
Hide resolved
...a/io/opentelemetry/instrumentation/api/incubator/semconv/db/DbClientAttributesExtractor.java
Outdated
Show resolved
Hide resolved
trask
commented
Nov 13, 2025
.../io/opentelemetry/instrumentation/api/incubator/semconv/db/SqlClientAttributesExtractor.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently built on top of #15139