Skip to content

Conversation

@al20878
Copy link
Contributor

@al20878 al20878 commented Jun 27, 2025

Minor improvement to allow quick sector size change [in code] if necessary

Copy link

@LegalizeAdulthood LegalizeAdulthood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ship it!

@al20878
Copy link
Contributor Author

al20878 commented Nov 17, 2025

Thanks @LegalizeAdulthood , but can you please merge it? I can't do it myself, so I'm not sure what "ship it" meant, exactly.
Also #28 needs the same attention, it was hanging there since June!

@LegalizeAdulthood
Copy link

Sorry, I don't have write access to this repository.

Ship it means deliver the goods.

e.g. this change looks fine to merge into the master branch.

Unfortunately, I don't have the capability to also do this for you, but a review is still worthwhile to the repository owner because it means someone other than the author has reviewed the change and found it acceptable.

@LegalizeAdulthood
Copy link

It looks like previous integrations were performed by @Rhialto but their profile page says they've moved all their efforts to gitlab (I guess they're unhappy with Microsoft buying github), so we'll need someone else from the OpenSIMH organization to do the merge.

@LegalizeAdulthood
Copy link

@pkoning2 Paul, can you do the honors?

@Rhialto
Copy link
Contributor

Rhialto commented Nov 18, 2025

It looks like previous integrations were performed by @Rhialto

I think that was just a merge request from me that was merged by Paul. At least if you're looking at #2 . (I should probably remember how I worked with this git-subtree stuff and update Macro-11 to the current version 0.9)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants