Conversation
RunContext.record_dir was inheriting the results root from the fetch/build contexts instead of receiving the per-run data directory. The new2old adapter now passes record_data_dir explicitly to Stepper.run(), so benchmarks using the compat layer see the correct run-specific path. RunContext.from_build() gains a record_dir parameter that overrides the inherited value when set. Stepper.run() forwards it. A roadmap entry is added for hierarchical record_dir across all phases once the new API is finalized. Signed-off-by: Antonio Paolillo <apaolill@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RunContext.record_dir was inheriting the results root from the fetch/build contexts instead of receiving the per-run data directory. The new2old adapter now passes record_data_dir explicitly to Stepper.run(), so benchmarks using the compat layer see the correct run-specific path.
RunContext.from_build() gains a record_dir parameter that overrides the inherited value when set. Stepper.run() forwards it.
A roadmap entry is added for hierarchical record_dir across all phases once the new API is finalized.