[Fix] Honor channel order for RGB TIFF images - #3337
Open
tandede wants to merge 1 commit into
Open
Conversation
tandede
force-pushed
the
tandede/fix-tifffile-channel-order
branch
from
August 21, 2026 10:50
c2cf607 to
fa75633
Compare
tandede
force-pushed
the
tandede/fix-tifffile-channel-order
branch
from
August 21, 2026 10:54
fa75633 to
bc7fff9
Compare
tandede
marked this pull request as ready for review
August 21, 2026 11:15
Author
|
Hi, I checked the current failed statuses. The CircleCI pipeline stops during configuration fetch with “No configuration was found in your project,” while both Read the Docs builds stop during configuration validation because |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #1101.
The
tifffilebackend returns standard color TIFF data in native RGB order, but MMCV's documented default is BGR. The backend previously returned the raw array without consultingchannel_order, so default reads displayed red and blue channels incorrectly.Modification
BC-breaking (Optional)
No. This makes the
tifffilebackend honor the existingchannel_ordercontract. Callers that need native RGB output can continue to passchannel_order='rgb'explicitly.Validation
pytest -q tests/test_image(61 passed)channel_orderbehavior.