Skip to content

[Feature] remove an 'assert' statement in favor of a 'raise' statement to make MultiScaleDeformableAttention compatible with torch.compile() - #3126

Open
isaacfinberg wants to merge 2 commits into
open-mmlab:mainfrom
isaacfinberg:isaacfinberg/remove_assert
Open

[Feature] remove an 'assert' statement in favor of a 'raise' statement to make MultiScaleDeformableAttention compatible with torch.compile()#3126
isaacfinberg wants to merge 2 commits into
open-mmlab:mainfrom
isaacfinberg:isaacfinberg/remove_assert

Conversation

@isaacfinberg

@isaacfinberg isaacfinberg commented Jun 7, 2024

Copy link
Copy Markdown

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

The goal is to make MultiScaleDeformableAttention compatible with torch.compile().

Modification

The only modification is to change an assert statement to a raise statement and add an error message.

BC-breaking (Optional)

N/A

Use cases (Optional)

The use case is using torch.compile() to make training and inference faster.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
  • CLA has been signed and all committers have signed the CLA in this PR.

@dinkarjuyal

Copy link
Copy Markdown

+1, this is a blocker for me as well

@CLAassistant

CLAassistant commented Jun 7, 2024

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@johnabel

Copy link
Copy Markdown

+1

@mgriffin1994

Copy link
Copy Markdown

+1, Would love for this to be fixed

@dtborders

Copy link
Copy Markdown

+1 would be great to see this fixed :)

@harshith2794

Copy link
Copy Markdown

+1 would be great to have this fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants