[WIP] Allow to use bucket storage policy #220
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fvennetier
reviewed
Jun 17, 2020
AymericDu
force-pushed
the
allow-to-use-bucket-storage-policy
branch
from
f166759 to
f58dca4
Compare
fvennetier
approved these changes
Jun 17, 2020
AymericDu
force-pushed
the
allow-to-use-bucket-storage-policy
branch
from
f58dca4 to
4a58605
Compare
fvennetier
approved these changes
Jun 17, 2020
AymericDu
force-pushed
the
allow-to-use-bucket-storage-policy
branch
from
4a58605 to
e4ee404
Compare
AymericDu
force-pushed
the
allow-to-use-bucket-storage-policy
branch
from
e4ee404 to
2d0041a
Compare
fvennetier
reviewed
Jun 18, 2020
| if memcache is not None: | ||
| memcache_key = "/".join( | ||
| ("versioning", self.account_name, root_container)) | ||
| version_policy = memcache.get(memcache_key) |
Member
There was a problem hiding this comment.
Isn't it possible to put that somewhere in the container sysmeta? This would allow to use the usual cache functions (e.g. clear_info_cache).
murlock
approved these changes
Jun 23, 2020
Contributor
murlock
left a comment
murlock
left a comment
There was a problem hiding this comment.
A functional test should be nice
AymericDu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable or disable the use of bucket storage policy.
When enabled, and if a storage policy is defined for a bucket (root container), all objects in this bucket will be uploaded with this storage policy.
The bucket storage policy can optionally be kept in the cache with its old value. To force the update of this value, it is enough to modify a property of this bucket via the AWS CLI (for example: add a tag).