Skip to content

Conversation

@jonathannorris
Copy link
Member

@jonathannorris jonathannorris commented Oct 20, 2025

Changes

  • Restructured Appendix C into a directory with sub-pages
  • Moved appendix-c-ofrep.mdappendix-c/index.md
  • Updated OFREP page to link to OpenAPI documentation

Related PR: open-feature/openfeature.dev#1283

@jonathannorris jonathannorris requested a review from a team as a code owner October 20, 2025 18:37
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @jonathannorris, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates an interactive OpenAPI documentation page for the OpenFeature Remote Evaluation Protocol (OFREP) into the existing documentation site. By leveraging Redocusaurus, it provides a dynamic and user-friendly interface for exploring the OFREP API specification, enhancing clarity and accessibility for developers.

Highlights

  • Documentation Structure: The Appendix C documentation for OFREP has been restructured into a dedicated directory, allowing for sub-pages and better organization.
  • File Renaming and Movement: The main Appendix C markdown file, appendix-c-ofrep.md, was renamed and moved to appendix-c/index.md to align with the new directory structure.
  • Interactive OpenAPI Documentation: A new page, ofrep-api.mdx, was added to embed an interactive OpenAPI viewer for the OFREP API using Redocusaurus, providing a dynamic way to explore the specification.
  • Sidebar Configuration: A _category_.json file was introduced to configure the sidebar for Appendix C, ensuring it remains non-collapsible and has a specific label and position within the navigation.
  • Navigation Update: The main Appendix C page (index.md) was updated to include a direct link to the newly added interactive OpenAPI documentation page.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@jonathannorris jonathannorris requested review from Copilot and removed request for a team October 20, 2025 18:38
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds interactive OpenAPI documentation for the OFREP (OpenFeature Remote Evaluation Protocol) using Redocusaurus, and restructures Appendix C to support multiple sub-pages.

Key Changes:

  • Restructured Appendix C from a single file into a directory with an index page and dedicated OpenAPI documentation page
  • Added Redocusaurus integration for interactive API documentation viewing
  • Configured sidebar behavior to prevent collapsing the Appendix C section

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
specification/appendix-c/ofrep-api.mdx New page containing embedded Redoc component for OpenAPI spec visualization
specification/appendix-c/index.md Updated main Appendix C page with link to new API documentation and adjusted sidebar position
specification/appendix-c/category.json Configuration file defining sidebar label, position, and collapse behavior for Appendix C section

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively adds an interactive OpenAPI documentation page for OFREP by restructuring the appendix and utilizing Redocusaurus. The changes are well-organized and achieve the goal described. I have a couple of suggestions to improve the maintainability of the new configuration and styling.

@jonathannorris jonathannorris force-pushed the feat-ofrep-openapi-docs branch from f4b9576 to dbf6df8 Compare October 27, 2025 19:00
@beeme1mr
Copy link
Member

Is the PR description accurate? I don't see where the OpenAPI docs are added.

@toddbaert
Copy link
Member

Is the PR description accurate? I don't see where the OpenAPI docs are added.

@beeme1mr

IIUC this is required so the the docs can actually be added in open-feature/openfeature.dev#1283

@jonathannorris
Copy link
Member Author

yea @beeme1mr sry this PR originally had the OpenAPI docs in them, but got moved to the docs page and the other repo. will update the description. mainly just route changes now.

@jonathannorris jonathannorris changed the title feat: add OpenAPI documentation page for OFREP feat: Update OFREP OpenAPI documentation Oct 29, 2025
github-merge-queue bot pushed a commit to open-feature/openfeature.dev that referenced this pull request Oct 29, 2025
…1283)

Integrates Redocusaurus to display interactive OpenAPI documentation for
OFREP.

## Changes

- Added `redocusaurus` dependency and preset configuration
- Added `scala` to Prism syntax highlighting (fixes OpenAPI spec
rendering)
- Added `docusaurus-theme-redoc` theme
- Added custom CSS for full-width Redoc layout while preserving left
navigation

## Features

- Embedded OpenAPI viewer with left nav visible
- Full-width layout for better API docs readability  
- Internal Redoc sidebar hidden (using theme config)
- Search disabled in Redoc viewer

## Related PR

Depends on: open-feature/spec#347
closes #1003

---------

Signed-off-by: Jonathan Norris <[email protected]>
@beeme1mr beeme1mr merged commit ed50557 into main Oct 29, 2025
7 checks passed
@beeme1mr beeme1mr deleted the feat-ofrep-openapi-docs branch October 29, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants