-
Notifications
You must be signed in to change notification settings - Fork 49
feat: Update OFREP OpenAPI documentation #347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @jonathannorris, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates an interactive OpenAPI documentation page for the OpenFeature Remote Evaluation Protocol (OFREP) into the existing documentation site. By leveraging Redocusaurus, it provides a dynamic and user-friendly interface for exploring the OFREP API specification, enhancing clarity and accessibility for developers. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds interactive OpenAPI documentation for the OFREP (OpenFeature Remote Evaluation Protocol) using Redocusaurus, and restructures Appendix C to support multiple sub-pages.
Key Changes:
- Restructured Appendix C from a single file into a directory with an index page and dedicated OpenAPI documentation page
- Added Redocusaurus integration for interactive API documentation viewing
- Configured sidebar behavior to prevent collapsing the Appendix C section
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| specification/appendix-c/ofrep-api.mdx | New page containing embedded Redoc component for OpenAPI spec visualization |
| specification/appendix-c/index.md | Updated main Appendix C page with link to new API documentation and adjusted sidebar position |
| specification/appendix-c/category.json | Configuration file defining sidebar label, position, and collapse behavior for Appendix C section |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request effectively adds an interactive OpenAPI documentation page for OFREP by restructuring the appendix and utilizing Redocusaurus. The changes are well-organized and achieve the goal described. I have a couple of suggestions to improve the maintainability of the new configuration and styling.
23e05dc to
04584ee
Compare
Signed-off-by: Jonathan Norris <[email protected]>
Signed-off-by: Jonathan Norris <[email protected]>
Signed-off-by: Jonathan Norris <[email protected]>
Signed-off-by: Jonathan Norris <[email protected]>
f4b9576 to
dbf6df8
Compare
Signed-off-by: Jonathan Norris <[email protected]>
|
Is the PR description accurate? I don't see where the OpenAPI docs are added. |
IIUC this is required so the the docs can actually be added in open-feature/openfeature.dev#1283 |
|
yea @beeme1mr sry this PR originally had the OpenAPI docs in them, but got moved to the docs page and the other repo. will update the description. mainly just route changes now. |
…1283) Integrates Redocusaurus to display interactive OpenAPI documentation for OFREP. ## Changes - Added `redocusaurus` dependency and preset configuration - Added `scala` to Prism syntax highlighting (fixes OpenAPI spec rendering) - Added `docusaurus-theme-redoc` theme - Added custom CSS for full-width Redoc layout while preserving left navigation ## Features - Embedded OpenAPI viewer with left nav visible - Full-width layout for better API docs readability - Internal Redoc sidebar hidden (using theme config) - Search disabled in Redoc viewer ## Related PR Depends on: open-feature/spec#347 closes #1003 --------- Signed-off-by: Jonathan Norris <[email protected]>
Changes
appendix-c-ofrep.md→appendix-c/index.mdRelated PR: open-feature/openfeature.dev#1283