Skip to content

Conversation

@gruebel
Copy link
Member

@gruebel gruebel commented Oct 31, 2025

This PR

  • found this out by accident and uv build supports it. more info can be found here

@gruebel gruebel requested review from a team as code owners October 31, 2025 15:48
@gemini-code-assist
Copy link

Summary of Changes

Hello @gruebel, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the license declaration within the pyproject.toml file to adhere to PEP 639 standards, enhancing compatibility with modern Python build tools. It also includes a minor version bump for the ruff-pre-commit hook.

Highlights

  • PEP639 License Compliance: The pyproject.toml file has been updated to use the PEP 639 compliant license = "Apache-2.0" and license-files = ["LICENSE"] fields, replacing the older license = { file = "LICENSE" } format.
  • Classifier Removal: The redundant License :: OSI Approved :: Apache Software License classifier has been removed from pyproject.toml as it is implicitly covered by the new license declaration.
  • Pre-commit Hook Update: The ruff-pre-commit hook version in .pre-commit-config.yaml has been upgraded from v0.14.2 to v0.14.3.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@codecov
Copy link

codecov bot commented Oct 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.89%. Comparing base (d03223e) to head (360a455).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #548   +/-   ##
=======================================
  Coverage   97.89%   97.89%           
=======================================
  Files          39       39           
  Lines        1849     1849           
=======================================
  Hits         1810     1810           
  Misses         39       39           
Flag Coverage Δ
unittests 97.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the project's license metadata in pyproject.toml to be compliant with PEP 639, which is a good improvement for modern Python packaging. The change correctly uses the SPDX identifier for the license and specifies the license file. Additionally, the ruff pre-commit hook version is updated. The changes are correct and follow best practices. I have no further comments.

Copy link
Member

@federicobond federicobond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@gruebel gruebel merged commit 4d0779c into main Oct 31, 2025
16 checks passed
@gruebel gruebel deleted the adjust-license-field branch October 31, 2025 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants