Skip to content

fix: Improve error handling in OpenFeatureClient #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2024
Merged

fix: Improve error handling in OpenFeatureClient #121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/OpenFeatureClient.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,9 +372,10 @@ private function evaluateFlag(
),
);

$error = $err instanceof ThrowableWithResolutionError ? $err->getResolutionError() : new ResolutionError(ErrorCode::GENERAL());
$error = $err instanceof ThrowableWithResolutionError ? $err->getResolutionError() : new ResolutionError(ErrorCode::GENERAL(), $err->getMessage());

$details = (new EvaluationDetailsBuilder())
->withFlagKey($flagKey)
->withValue($defaultValue)
->withReason(Reason::ERROR)
->withError($error)
Expand Down
10 changes: 8 additions & 2 deletions tests/unit/OpenFeatureClientTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -499,6 +499,7 @@ public function testClientEvaluationDetailsAbnormalExecutionHasErrorCodeField():
$resolutionError = $actualDetails->getError();
$this->assertNotNull($resolutionError);
$this->assertEquals($expectedErrorCode, $resolutionError->getResolutionErrorCode());
$this->assertEquals('flagKey', $actualDetails->getFlagKey());
}

/**
Expand Down Expand Up @@ -563,9 +564,14 @@ public function testClientShouldLogInformativeErrorDuringAbnormalExecution(): vo
$client = new OpenFeatureClient($api, 'test-name', 'test-version');
$client->setLogger($mockLogger);

$value = $client->getBooleanValue('flagKey', false);
$details = $client->getBooleanDetails('flagKey', false);

$this->assertEquals($value, false);
$this->assertEquals(false, $details->getValue());
$this->assertEquals('flagKey', $details->getFlagKey());

$this->assertInstanceOf(ResolutionError::class, $details->getError());
$this->assertEquals(ErrorCode::GENERAL(), $details->getError()->getResolutionErrorCode());
$this->assertEquals('NETWORK_ERROR', $details->getError()->getResolutionErrorMessage());
}

/**
Expand Down