Gracefully disconnect socket when acquisition stops #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bparks13
commented
Mar 13, 2025
bparks13
commented
- If the server was disconnected during acquisition, and the plugin is trying to automatically reconnect, it will now disconnect if acquisition stops to prevent it going into an unrecoverable state
- Update the Python script so it waits to initialize the server until after the user provides keyboard input. This prevents the client from connecting, deciding it can't read any data, and disconnecting
- Bump version to 0.4.1 for version 0.6.7 of the GUI
- If the server was disconnected during acquisition, and the plugin is trying to automatically reconnect, it will now disconnect if acquisition stops to prevent it going into an unrecoverable state - Update the Python script so it waits to initialize the server until after the user provides keyboard input. This prevents the client from connecting, deciding it can't read any data, and disconnecting - Bump version to 0.4.1
Fix Windows workflow to use new endpoint for open-ephys library
anjaldoshi
approved these changes
Mar 13, 2025
Collaborator
anjaldoshi
left a comment
anjaldoshi
left a comment
There was a problem hiding this comment.
Had to fix the Windows workflow to use the new endpoint to get the open-ephys.lib. Also, replaced Artifactory API key with access token.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.