Skip to content

Conversation

@Sfonxu
Copy link
Contributor

@Sfonxu Sfonxu commented Oct 29, 2025

No description provided.

@AgnieszkaZaba
Copy link
Collaborator

reopen to trigger CI

@AgnieszkaZaba AgnieszkaZaba reopened this Nov 24, 2025
@slayoo
Copy link
Member

slayoo commented Nov 24, 2025

@AgnieszkaZaba, @Sfonxu, I wonder if we shouldn't place the NUMBA_THREADING_LAYER setting outside of the colab conditional? This is equally important on Colab, and elsewhere!

@AgnieszkaZaba
Copy link
Collaborator

@slayoo we can definitely do it. So we want to set it up for all platforms?
@Sfonxu Probably we can rename colab header, to some env setup, but still keep it in this one cell? I'm doing small test locally. If they pass, I think we should merge it and set as new version and then test outside (not like a local package).

@slayoo
Copy link
Member

slayoo commented Nov 24, 2025

So we want to set it up for all platforms?

Colab uses ordinary Linux, so if it is essential for Colab, it is also essential for any Linux user. Windows and macOS seem to have the same threading layer priority, so to prevent the same happening on nacOS and Windows, we'd best not limit the setting to Colab or Linux

IMG_20251124_202753.jpg

@slayoo
Copy link
Member

slayoo commented Nov 24, 2025

one caveat with the env var setting: if we consider how we run the smoke tests, and notebooks within them using notebook_vars, we might end up with import numba statements being run before running notebook code, hence the env var setting will be ignored. But then, we have the safeguard assets which will anyhow detect it, so no harm to have in in the notebooks, I think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants