You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi @ritmas thanks for sharing your code.
As specified in SMPP 3.4 section 2.7, using transceiver mode is to enter a fully duplex messaging mode where messages are simultaneously sent and received on the socket.
This is a very different way of communicating compared our current mode, where we can send a reply and simply wait for response. We know that our response will come, and can do blocking reads for it until it arrives or times out. The only complication we deal with now, is that a enquire_link message might be waiting for us in the socket buffer when we read.
Doing transceiver, even in a synchronous way, means this entire mechanism would require reworking, also we have to deal with any messages that are received in a timely manner, for instance if a delivery report is received we have to deal with it before sending a lot of new messages to the SMSC, since we have to acknowledge the PDU.
Please read page 26-28 of the specs SMPP 3.4 carefully and let me know how this simple PR fares against it.
If you come up with a more complete implementation, and some way of testing it, I will be happy to accept a PR.
Well, the way I'm using transceiver for certain SMSC connections is enabling two sockets at the same time:
for sending SMS, which is being opened and closed on-demand
for reading inbound messages & delivery reports, persistent one
There's a chance I haven't fall into blocking-read situation yet, so I agree more info/tests are required.
Do you have any particular tool or SMS gateway in mind to use for emulating such transceiver specific scenarios?
The reason will be displayed to describe this comment to others. Learn more.
Thanks, it did the trick for me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.