Skip to content

Remove aria-multiselectable #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JacobDB wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove aria-multiselectable #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions docs/js/demo.bundle.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -618,7 +618,6 @@
_this.options = Object.assign({}, Handorgel.defaultOptions, options);
_this._listeners = {};
_this._bindEvents();
_this._initAria();
_this.update();
return _this;
}
Expand Down Expand Up @@ -684,7 +683,6 @@
fold.destroy();
});
this._unbindEvents();
this._cleanAria();

// clean reference to handorgel instance
this.element.handorgel = null;
Expand All @@ -702,21 +700,6 @@
}
});
}
}, {
key: "_initAria",
value: function _initAria() {
if (!this.options.ariaEnabled) {
return;
}
if (this.options.multiSelectable) {
this.element.setAttribute('aria-multiselectable', 'true');
}
}
}, {
key: "_cleanAria",
value: function _cleanAria() {
this.element.removeAttribute('aria-multiselectable');
}
}, {
key: "_bindEvents",
value: function _bindEvents() {
Expand Down
17 changes: 0 additions & 17 deletions lib/js/esm/handorgel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -616,7 +616,6 @@ var Handorgel = /*#__PURE__*/function (_EventEmitter) {
_this.options = Object.assign({}, Handorgel.defaultOptions, options);
_this._listeners = {};
_this._bindEvents();
_this._initAria();
_this.update();
return _this;
}
Expand Down Expand Up @@ -682,7 +681,6 @@ var Handorgel = /*#__PURE__*/function (_EventEmitter) {
fold.destroy();
});
this._unbindEvents();
this._cleanAria();

// clean reference to handorgel instance
this.element.handorgel = null;
Expand All @@ -700,21 +698,6 @@ var Handorgel = /*#__PURE__*/function (_EventEmitter) {
}
});
}
}, {
key: "_initAria",
value: function _initAria() {
if (!this.options.ariaEnabled) {
return;
}
if (this.options.multiSelectable) {
this.element.setAttribute('aria-multiselectable', 'true');
}
}
}, {
key: "_cleanAria",
value: function _cleanAria() {
this.element.removeAttribute('aria-multiselectable');
}
}, {
key: "_bindEvents",
value: function _bindEvents() {
Expand Down
2 changes: 1 addition & 1 deletion lib/js/esm/handorgel.min.js
View file
Open in desktop

Large diffs are not rendered by default.

13 changes: 0 additions & 13 deletions lib/js/handorgel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,7 +450,6 @@ class Handorgel extends evEmitter {
this.options = Object.assign({}, Handorgel.defaultOptions, options);
this._listeners = {};
this._bindEvents();
this._initAria();
this.update();
}
update() {
Expand Down Expand Up @@ -509,7 +508,6 @@ class Handorgel extends evEmitter {
fold.destroy();
});
this._unbindEvents();
this._cleanAria();

// clean reference to handorgel instance
this.element.handorgel = null;
Expand All @@ -525,17 +523,6 @@ class Handorgel extends evEmitter {
}
});
}
_initAria() {
if (!this.options.ariaEnabled) {
return;
}
if (this.options.multiSelectable) {
this.element.setAttribute('aria-multiselectable', 'true');
}
}
_cleanAria() {
this.element.removeAttribute('aria-multiselectable');
}
_bindEvents() {
this._listeners.foldOpen = this._handleFoldOpen.bind(this);
this.on('fold:open', this._listeners.foldOpen);
Expand Down
2 changes: 1 addition & 1 deletion lib/js/handorgel.min.js
View file
Open in desktop

Large diffs are not rendered by default.

17 changes: 0 additions & 17 deletions lib/js/umd/handorgel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -622,7 +622,6 @@
_this.options = Object.assign({}, Handorgel.defaultOptions, options);
_this._listeners = {};
_this._bindEvents();
_this._initAria();
_this.update();
return _this;
}
Expand Down Expand Up @@ -688,7 +687,6 @@
fold.destroy();
});
this._unbindEvents();
this._cleanAria();

// clean reference to handorgel instance
this.element.handorgel = null;
Expand All @@ -706,21 +704,6 @@
}
});
}
}, {
key: "_initAria",
value: function _initAria() {
if (!this.options.ariaEnabled) {
return;
}
if (this.options.multiSelectable) {
this.element.setAttribute('aria-multiselectable', 'true');
}
}
}, {
key: "_cleanAria",
value: function _cleanAria() {
this.element.removeAttribute('aria-multiselectable');
}
}, {
key: "_bindEvents",
value: function _bindEvents() {
Expand Down
2 changes: 1 addition & 1 deletion lib/js/umd/handorgel.min.js
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 0 additions & 16 deletions src/js/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ export default class Handorgel extends EventEmitter {
this._listeners = {}

this._bindEvents()
this._initAria()
this.update()
}

Expand Down Expand Up @@ -100,7 +99,6 @@ export default class Handorgel extends EventEmitter {
})

this._unbindEvents()
this._cleanAria()

// clean reference to handorgel instance
this.element.handorgel = null
Expand All @@ -119,20 +117,6 @@ export default class Handorgel extends EventEmitter {
})
}

_initAria() {
if (!this.options.ariaEnabled) {
return
}

if (this.options.multiSelectable) {
this.element.setAttribute('aria-multiselectable', 'true')
}
}

_cleanAria() {
this.element.removeAttribute('aria-multiselectable')
}

_bindEvents() {
this._listeners.foldOpen = this._handleFoldOpen.bind(this)
this.on('fold:open', this._listeners.foldOpen)
Expand Down