test(e2e): fold opencode host e2e onto shared agent-name constant - #3656
Merged
PattaraS merged 1 commit intoJul 31, 2026
Merged
Conversation
Follow-up to omnigent-ai#3599 (PR 1.7). That PR moved the built-in native agent-name constants into a shared public block in omnigent/native_coding_agents.py and migrated the claude/codex host e2e tests onto them, but missed the opencode sibling: test_host_opencode_native_e2e.py still defined a local _OPENCODE_NATIVE_AGENT_NAME = "opencode-native-ui" literal and asserted a stale '_ensure_default_opencode_agent did not run' message (that per-harness seeder was collapsed into _ensure_default_native_agents). Import the shared OPENCODE_NATIVE_AGENT_NAME constant and update the message so all three host e2e tests are consistent. Test-only; opt-in e2e (skipped without OMNIGENT_E2E_OPENCODE_NATIVE=1). Co-authored-by: Isaac Signed-off-by: Pat Sukprasert <pattara.sk127@gmail.com>
13 tasks
Contributor
|
🏷️ Doc impact: The change only refactors an e2e test to import the agent-name constant instead of hardcoding it, touching no user-facing surface, integration, or documented behavior. Auto-classified on merge. Set the label manually before merging to override. · run |
13 tasks
PattaraS
added a commit
that referenced
this pull request
Jul 31, 2026
…ospective (#3658) Phase 1 of the modular native-harness registry refactor landed (10 PRs, 2026-07-28 → 07-31). Bring the design doc in line with what actually shipped: - Status header, Phase 1 subtotal, effort summary, and bottom line updated from forward-looking ('1.1–1.3 in review') to Phase 1 complete / Phase 2 next. - Ledger: 1.8 (#3648) landed; 1.4 marked descoped (with rationale); the 1.7 opencode-e2e follow-up (#3656) recorded; per-PR merge dates added. - Calibration rewritten as a Phase 1 retrospective: estimate (~20–29 eng-days) vs. actual (10 PRs / 4 calendar days), the real cost centers (test-shape churn + review-caught behavior bugs, enumerated per PR), the correct runner re-scope, the two intentional behavior deltas (qwen label, antigravity relay), and the recurring uv.lock / full-suite-only-flake operational friction. Doc-only; no code change. Co-authored-by: Isaac Signed-off-by: Pat Sukprasert <pattara.sk127@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
N/A — follow-up cleanup to #3599 (PR 1.7 of the modular native-harness registry workstream).
Summary
#3599 moved the built-in native agent-name constants into a shared public block in
omnigent/native_coding_agents.py(CLAUDE_NATIVE_AGENT_NAME…KIMI_NATIVE_AGENT_NAME) andmigrated the claude/codex host e2e tests onto them — but missed the opencode sibling. This
completes the sweep:
tests/e2e/test_host_opencode_native_e2e.pynow imports the sharedOPENCODE_NATIVE_AGENT_NAMEconstant instead of its own local_OPENCODE_NATIVE_AGENT_NAME = "opencode-native-ui"literal.(
_ensure_default_opencode_agent); updated to the collapsed loop_ensure_default_native_agents.All three host e2e tests (claude/codex/opencode) are now consistent. Caught by Polly's review
on #3599, but only after that PR had merged — hence this small standalone follow-up.
Test Plan
Test-only, and opt-in:
test_host_opencode_native_e2e.pyis skipped unlessOMNIGENT_E2E_OPENCODE_NATIVE=1(needs a pinnedopencodebinary + LLM creds). Verified thefile parses, imports the shared constant, and passes
ruff check. The referenced symbolOPENCODE_NATIVE_AGENT_NAMEexists onmain(landed in #3599).Demo
N/A — test-only, no user-facing change.
Type of change
Test coverage
Coverage notes
Behavior-preserving test cleanup: swaps a hardcoded literal for the equivalent shared constant
(same value,
"opencode-native-ui") and fixes a stale assertion message string. No assertionlogic changes. The opt-in e2e is unchanged in what it exercises.