Mandate that axis field names are strings - #60
Merged
Merged
Conversation
Automated Review URLs |
jo-mueller
approved these changes
Mar 13, 2026
Contributor
|
Thank you, @dstansby ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A minor improvement that it might be worth adding to OME-Zarr 0.6.
For OME-Zarr 0.5, it's already implicit that axis names have to be
stringornullbecause they have to match thedimension_namesZarr metdata. I'm proposing here to tighten this to require non-empty strings for all axis names.There is no change to the schemas because they already encode this constraint.