fix: gh icon as relative path#170
Merged
Merged
Conversation
Automated Review URLs |
lubianat
requested changes
Jul 2, 2026
|
|
||
| if "github" in author: | ||
| name += f" [<img src=\"{github_icon}\" alt=\"GitHub\" height=12 width=12 style=\"vertical-align: middle;\"/>](https://github.com/{author['github']})" | ||
| name += f" [<img src=icons/invertocat.svg alt=\"GitHub\" height=12 width=12 style=\"vertical-align: middle;\"/>](https://github.com/{author['github']})" |
Contributor
There was a problem hiding this comment.
will this actually fix it? it seems that it does not find this path on the rendered version
maybe using https://github.githubassets.com/favicons/favicon.svg is safer?
on ome/ngff#552 it looks like this to me:
Contributor
Author
There was a problem hiding this comment.
Over here this results in
Contributor
Author
There was a problem hiding this comment.
which is why I went for the slightly altered, but stored in the repo version of the octocat.
will this actually fix it?
I hope so, because the path to the icon was previously written as an absolute path (/path...), which worked in the ngff-spec repo, where root and relative path are the same. Hopefully turning it into a relative path will fix it though! But only one way to find out...
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for the mildly annoying render of the authorlist over at this issue ome/ngff#553
@lubianat @joshmoore