parsesmi: support LF and CRLF line endings#32
Open
Okimoka wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello
I've encountered 2 small bugs working with EYE-EEG:
parsesmi, causing the file to use linux style line endings:With the current version of parsesmi, this crashes with:
Changing the regexes in
parsesmi.mto match "\r?\n" (like inparseeyelink.m) fixes this.detecteyemovements.m, the final console summary says it prints the velocity thresholds as the mean across epochs, but the horizontal threshold was actually taken froml_msdx(e)/r_msdx(e), whereeis the last epoch index from the loop. As a result, the horizontal threshold reflected only the last epoch. This only affects the console summary and can be fixed by removing the index