CORE-1223: bump all python instrumentations to 0.62b1 - last py3.9 instrumentation#213
Merged
natyharary merged 2 commits intoJul 5, 2026
Conversation
tamirdavid1
reviewed
Jul 5, 2026
| encoded_span = original_encode_span(sdk_span) | ||
| # THE FIX: fold the W3C trace flags into Span.flags (PR #4761). | ||
| encoded_span.flags |= int(sdk_span.get_span_context().trace_flags) | ||
| span_context = sdk_span.get_span_context() |
Collaborator
There was a problem hiding this comment.
can you explain this please?
Collaborator
Author
There was a problem hiding this comment.
ty gave a warning on that: get_span_context() can return SpanContext or None.
if span_context is None then calling span_context.trace_flags will result in an exception and kill the entire process.
so we check for nullability, and if not null... we proceed
tamirdavid1
approved these changes
Jul 5, 2026
natyharary
deleted the
core-1223-update-python-instrumentation-for-latest-py39
branch
July 5, 2026 19:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Changelog entry: Does this PR introduce a user-facing bug fix, feature, dependency update, or breaking change??