fix: extract codeAttributes from container_config.traces#199
Merged
tamirdavid1 merged 3 commits intoMay 13, 2026
Conversation
The server sends codeAttributes inside the container_config config map entry at traces.codeAttributes, but get_remote_config only looked for it under the empty-string config_map key which the server never sends. This caused code attributes to always default to False. Also renames the misleading sample_config field/variable to container_config since it holds the full container configuration, not just sampling config.
blumamir
approved these changes
May 13, 2026
Comment on lines
+313
to
+316
| try: | ||
| config.span_metrics_mode = container_config['traces']['headSampling']['spanMetricsMode'] | ||
| except (KeyError, TypeError): | ||
| pass |
Collaborator
There was a problem hiding this comment.
is it the idomatic way in python to check for properties in json which can be null?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The server sends codeAttributes inside the container_config config map entry at traces.codeAttributes, but get_remote_config only looked for it under the empty-string config_map key which the server never sends. This caused code attributes to always default to False.
Also renames the misleading sample_config field/variable to container_config since it holds the full container configuration, not just sampling config.
Changelog entry: Does this PR introduce a user-facing bug fix, feature, dependency update, or breaking change??
emergency-ticket id: EMR-1693