view: various small improvements#590
Open
CounterPillow wants to merge 1 commit intonyaadevs:masterfrom
Open
Conversation
Contributor
CounterPillow
commented
Oct 12, 2019
CounterPillow
commented
- Don't render an edit form for comments that can no longer be edited.
- Use the markdown editor that has a preview, because duh.
- Don't make the infobubble JS error out on pages without the infobubble.
1. Don't render an edit form for comments that can no longer be edited. 2. Use the markdown editor that has a preview, because duh. 3. Don't make the infobubble JS error out on pages without the infobubble.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.