-
-
Notifications
You must be signed in to change notification settings - Fork 46
feat: nitro hook robots:init
and robots:robots-txt:input
#235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
robots:init
and robots:robots-txt:input
β¦odules/robots into feat/new-nitro-hooks
Thanks for cracking on with this. Looking at the comments in the readme perhaps I was actually trying to use this differently than planned. So I think it'd be good to think about how I would be recommended to use it for my purposes. As far as I understand,
This is pretty good, and in my case, my module requires some default groups are added to prevent robots accessing CMS pages. But then I am adding website user abilities to configure to some of the robot options through a website settings page.
Therefore I'd expect to put this configuration into the new hook currently named The consideration I'd have is when sitemap needs this information it calls upon I think while we are here it'd be good to configure how this composable can be called consistently and respecting whatever is done in the runtime hook. I think in the current setup that this may not happen. I might be wrong, but this could be a reason why my sitemap was working when I deployed and then failed later after a few hours sometimes. I've got a chunk of work right now but if I can jump in on some tasks on this PR I will - so long as we are coordinated on what to work on so we don't double up or conflict code :) |
Sorry, happy to revert, just seeing if there was a workaround - feels like the Nitro plugins aren't mapped properly from the Nuxt test-utils? Was just curious when I saw this and had 5 mins to see if there were other ways we could map to the plugin in the fixture |
π Linked issue
Further work in improving #233
β Type of change
π Description
We need more granular hooks where we can have more preditable input / output without having to renormalize input that is already normalized.