Generate trigonometric constants and lookup tables using Sollya #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seiko2plus
force-pushed
the
impl-sincos-data
branch
from
e6bbf0e to
b04b070
Compare
Added precomputed constants and lookup tables for sine/cosine functions generated with Sollya. These tables include: - Pi constants with different precision levels for float and double types - Sine approximation tables for fast trigonometric calculations - Angle reduction constants - KPi/16 inline constants for range reduction The data was generated using the 'spin sollya' tool and separated into multiple header files to reduce code size and improve organization. Files added: - npsr/trig/data/approx.h: Sine approximation tables - npsr/trig/data/constants.h: Pi and other trigonometric constants - npsr/trig/data/data.h: Main data header - npsr/trig/data/kpi16-inl.h: KPi/16 inline constants - npsr/trig/data/reduction.h: Angle reduction constants
seiko2plus
force-pushed
the
impl-sincos-data
branch
from
31d2b18 to
4a81e0c
Compare
|
Thanks @seiko2plus, this should probably have gone in with the first PR so it worked so I'm happy to get this in and then look at the more interesting generator 😸 |
|
Thank you @Mousius, now I can re-base numpy/numpy#29699 and make it ready for review. The generator is lives now in #5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
note: It will be re-based later after merges #1.Added precomputed constants and lookup tables for sine/cosine functions generated with Sollya.
These tables include:
The data was generated using the 'spin sollya' tool and separated into multiple header files
to reduce code size and improve organization.
Files added:
npsr/trig/data/approx.h: Sine approximation tables
npsr/trig/data/constants.h: Pi and other trigonometric constants
npsr/trig/data/data.h: Main data header
npsr/trig/data/kpi16-inl.h: KPi/16 inline constants
npsr/trig/data/reduction.h: Angle reduction constants