Skip to content

[Omni] Fix popup Snap watermark response handling#84

Merged
olgahaha merged 2 commits into
mainfrom
omni/e42f8a19/proofsnap-extension
May 6, 2026
Merged

[Omni] Fix popup Snap watermark response handling#84
olgahaha merged 2 commits into
mainfrom
omni/e42f8a19/proofsnap-extension

Conversation

@numbers-official
Copy link
Copy Markdown
Collaborator

@numbers-official numbers-official commented May 6, 2026

Summary

Fixes popup-initiated Snap captures saving without a watermark. The popup runtime listener now ignores unrelated messages synchronously so the offscreen document can respond to ADD_WATERMARK while the popup remains open.

Changes

  • Narrowed the popup chrome.runtime.onMessage handler to UPLOAD_PROGRESS only.
  • Moved upload-progress async work into a fire-and-forget task so the listener does not return a Promise to the Chrome runtime.
  • Kept selection overlay injection unchanged; no broad host permissions added.

Verification

  • gh pr checks 84: ci pass
  • npm run type-check: pass
  • npm run lint: 0 errors, existing warnings only
  • npm run build: pass

Generated by Olga Shen with Omni

@numbers-official numbers-official changed the title [Omni] Fix Snap Selection startup on valid pages [Omni] Fix snap selection startup handling May 6, 2026
@numbers-official numbers-official changed the title [Omni] Fix snap selection startup handling [Omni] Fix popup Snap watermark response handling May 6, 2026
@olgahaha olgahaha merged commit 1d3dce9 into main May 6, 2026
1 check passed
@olgahaha olgahaha deleted the omni/e42f8a19/proofsnap-extension branch May 6, 2026 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants