Fixed basePath for macOS#86
Open
paulofduarte wants to merge 2 commits into
Open
Conversation
|
I'm also a macOS user, and can confirm this works for me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For macOS the executable doesn't use the executable binary location to infer the basePath.
Because of this an installed nuked-sc55 will require the back.data and the roms to be in the current directory to work. This PR implements a similar approach as it was done for Linux to define the basePath and fix the problem.
As this change touches the same lines as #66 and will cause conflicts I had also changed:
basePath = Files::dirname(self_path);intobasePath = Files::real_dirname(self_path);and changed the console of of the basePath to happen after the check for../shared/nuked-sc55and to usebasePathinstead ofargv[0]. So this PR also achieves the same results as #66.