fix(runner/signoz): use GET for autocomplete label/value suggests#516
Merged
Conversation
signoz_label_suggest and signoz_value_suggest issued POST to
/api/v3/autocomplete/attribute_{keys,values}, but Signoz serves those
endpoints via GET — so they return HTTP 404 and log-search label/value
autocomplete never populates.
Switch both to GET with the action_params flattened into the URL query
string (dataSource/aggregateOperator/searchText/limit/...). Add a get
helper and factor the shared auth/send/read into do so post is unchanged;
query_range stays POST. Extend the routing test to assert HTTP method.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the SigNoz client to use GET requests instead of POST requests for the label and value autocomplete suggestion endpoints, introducing a toQuery helper to convert parameters into URL query values and refactoring request execution into a shared do method. Feedback was provided to optimize the toQuery function by using a type assertion to avoid a double JSON roundtrip when params is already a map[string]any, and to handle integer types directly in the type switch.
Contributor
|
📦 Image Tags Updated |
mayankpande88
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
signoz_label_suggest and signoz_value_suggest issued POST to /api/v3/autocomplete/attribute_{keys,values}, but Signoz serves those endpoints via GET — so they return HTTP 404 and log-search label/value autocomplete never populates.
Switch both to GET with the action_params flattened into the URL query string (dataSource/aggregateOperator/searchText/limit/...). Add a get helper and factor the shared auth/send/read into do so post is unchanged; query_range stays POST. Extend the routing test to assert HTTP method.
Summary
Type of change
Chart version
versionincharts/nudgebee-agent/Chart.yaml(required for user-visible changes)Test plan
helm lint charts/nudgebee-agentpassesct lint --config .github/configs/ct.yamlpasseshelm templateoutput reviewedRelated issues