fix(chronosphere): traces endpoint 404 + auto-enable traces + report trace URL#515
Merged
Merged
Conversation
…ble path)
The Go chronosphere client POSTed trace queries to
/api/unstable/data/traces/searches, which Chronosphere returns 404 for
('No endpoint found'). The correct endpoint — and the one the legacy agent
uses, and the one the backend builds the ListTraces body for (query_type,
tag_filters, time range) — is /api/v1/data/traces. Verified directly against
Chronosphere: the unstable path 404s, /api/v1/data/traces accepts the request
(400 'query type is required' with an empty body, i.e. endpoint + Bearer auth
are valid). This is why the Traces view showed 'No Data Available' despite the
provider being correctly detected as Chronosphere.
Chart bumped to 0.1.9.
There was a problem hiding this comment.
Code Review
This pull request updates the Chronosphere trace query API path from /api/unstable/data/traces/searches to /api/v1/data/traces in both the client implementation and its corresponding tests, as the previous path returned 404 errors. Additionally, the Helm chart version for nudgebee-agent has been bumped to 0.1.9. I have no feedback to provide.
RamanKharchee
previously approved these changes
Jul 10, 2026
Contributor
|
📦 Image Tags Updated |
…nt URL Two follow-on fixes so Chronosphere traces work without workarounds: - Chart: setting runner.chronosphere.url now also emits CHRONOSPHERE_TRACES_ENABLED=true (new runner.chronosphere.tracesEnabled, default true) and optional CHRONOSPHERE_TRACES_URL. Previously the traces status flag had no values key and needed a raw additional_env_vars entry. - Telemetry: traceURL now reports the Chronosphere endpoint (explicit traces URL, else CHRONOSPHERE_URL) for the chronosphere provider instead of empty, so the health panel shows the real backend instead of a 'localhost' placeholder.
Contributor
|
📦 Image Tags Updated |
RamanKharchee
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes Chronosphere traces work end-to-end for a customer whose Traces view showed No Data Available despite the provider being detected correctly.
1. Wrong trace endpoint (the functional bug)
The Go client POSTed to
/api/unstable/data/traces/searches, which Chronosphere 404s. The correct path (legacy agent's, and the one the backend builds theListTracesbody for) is/api/v1/data/traces.Verified live against the customer's Chronosphere:
2. Chart: auto-enable the traces provider
The Traces status reads
CHRONOSPHERE_TRACES_ENABLED, which the chart never wired — so it needed a rawadditional_env_varsworkaround even thoughrunner.chronosphere.urlwas set. Now settingrunner.chronosphere.urlalso emitsCHRONOSPHERE_TRACES_ENABLED=true(newrunner.chronosphere.tracesEnabled, default true) plus optionalCHRONOSPHERE_TRACES_URL.3. Report the trace endpoint instead of
localhostFor the Chronosphere provider the agent reported an empty traces URL, so the health panel showed a
localhostplaceholder.traceURL()now returns the explicit traces URL (orCHRONOSPHERE_URL).Tests
Unit tests updated/added (endpoint path, traceURL for chronosphere).
go build,go vet, fullgo test ./..., gofmt, andhelm templateall pass. Live end-to-end query returns real trace data. Chart bumped to 0.1.9.