fix(misc): scan package projects for env vars - #36847
Open
barbados-clemens wants to merge 2 commits into
Open
Conversation
✅ Deploy Preview for nx-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
View your CI Pipeline Execution ↗ for commit 8978c55
☁️ Nx Cloud last updated this comment at |
the wider conformance scan needs an explicit baseline for supported and internal package variables.
the nx-only file map let undocumented variables in other published packages pass conformance.
barbados-clemens
marked this pull request as ready for review
September 1, 2026 14:42
AgentEnder
enabled auto-merge (squash)
September 1, 2026 14:43
AgentEnder
approved these changes
Sep 1, 2026
barbados-clemens
force-pushed
the
nxc-4909
branch
from
September 1, 2026 14:43
2b8b220 to
8978c55
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
The environment-variable conformance rule only inspected
packages/nx, so variables in other package projects could bypass documentation checks.Expected Behavior
All
packages/*projects participate in the check, with existing variables explicitly documented or classified as internal.The following variables are now documented:
NX_DOCKER_IMAGE_REFNX_ENABLE_TS_SYNC_TRANSITIVE_DEPENDENCIESNX_GRADLE_BATCH_DEBUGNX_GRADLE_VERBOSE_LOGGINGNX_IGNORE_UNSUPPORTED_TS_SETUPNX_VERBOSE_LOGGING_PATH_MAPPINGSRelated Issue(s)
Fixes NXC-4909: https://linear.app/nxdev/issue/NXC-4909/investigate-why-conformance-missed-the-env-var