Skip to content

CRACEN: Avoid possible race-condition on exit_ikg #25734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
frkv wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −1
Open

CRACEN: Avoid possible race-condition on exit_ikg #25734

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion subsys/nrf_security/src/drivers/cracen/cracenpsa/src/ikg_signature.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,15 @@ static int exit_ikg(struct sx_pk_acq_req *pkreq)
{

int status;
struct sx_pk_acq_req oldreq = *pkreq;

sx_pk_release_req(pkreq->req);
Copy link
Contributor

@degjorva degjorva Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with this as a quick patch, but it is quite ugly. Would it not be better here to create a "sx_pk_change_req_cmd" function and then just reuse the same req with the new command instead of acquiring two of them? That would also be more generic so we can use that as a pattern in the other functions that have multiple command changes.

Copy link
Contributor Author

@frkv frkv Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can update the previous PR (this) with your idea so we have a comparison

/* Acquiring just before releasing ensures that there is at least one user
* requesting asymmetric engine support. This is done to avoid powering
* down CRACEN before ongoing operations have finalized. This relies on
* recursive mutex locking.
*/
*pkreq = sx_pk_acquire_req(SX_PK_CMD_IK_EXIT);
sx_pk_release_req(oldreq.req);
pkreq->status = sx_pk_list_ik_inslots(pkreq->req, 0, NULL);
if (pkreq->status) {
return pkreq->status;
Expand Down