-
Notifications
You must be signed in to change notification settings - Fork 1.4k
samples: matter: Fixed Matter 1.5 compliance issues #25715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
samples: matter: Fixed Matter 1.5 compliance issues #25715
Conversation
kkasperczyk-no
commented
Nov 21, 2025
- Regenerated files and pulled changes to fix issue with incorrect Access Control cluster revision and enabled provisional ConfigurationVersion
- Fixed persisting DevKitName attribute
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses Matter 1.5 compliance issues by downgrading the Access Control cluster from revision 3 to revision 2, removing provisional features that were incorrectly included. The changes regenerate ZAP files across multiple Matter samples and fix the DevKitName attribute storage in the manufacturer_specific sample.
Key Changes
- Downgraded Access Control cluster revision from 3 to 2 across all Matter samples
- Removed provisional kAuxiliary feature, AccessControlAuxiliaryTypeEnum, auxiliaryACL attribute, and AuxiliaryAccessUpdated event
- Changed DevKitName attribute storage from RAM to NVM in manufacturer_specific sample
Reviewed Changes
Copilot reviewed 143 out of 143 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| west.yml | Updates Matter SDK revision reference |
| samples/matter/*/access.h | Removes AuxiliaryAccessUpdated event from generated access control macros |
| samples/matter//.matter | Downgrades Access Control cluster revision and removes provisional auxiliary features |
| samples/matter/manufacturer_specific/src/default_zap/endpoint_config.h | Adds TOKENIZE flag for DevKitName attribute persistence |
| samples/matter/manufacturer_specific/src/default_zap/manufacturer_specific.zap | Changes DevKitName storage from RAM to NVM and updates default values |
| samples/matter/manufacturer_specific/src/default_zap/zcl.json | Updates xmlRoot path to use full relative path |
| samples/matter/manufacturer_specific/src/default_zap/zap-generated/clusters/AccessControl/* | Removes auxiliary access control structs, enums, events, and attributes |
| samples/matter/common/src/zap_samples.yml | Adds closure sample entry |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
The following west manifest projects have changed revision in this Pull Request:
✅ All manifest checks OK Note: This message is automatically posted and updated by the Manifest GitHub Action. |
CI InformationTo view the history of this post, click the 'edited' button above Inputs:Sources:sdk-nrf: PR head: ed47f2d4ead253761ccb01d7f5651b6fb53c45fb more detailssdk-nrf:
matter:
Github labels
List of changed files detected by CI (335)Outputs:ToolchainVersion: df3cc9d822 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
|
You can find the documentation preview for this PR here. |
ffd37b2 to
c7044c9
Compare
c7044c9 to
3e68da5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 143 out of 143 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...er/manufacturer_specific/src/default_zap/zap-generated/clusters/AccessControl/AttributeIds.h
Outdated
Show resolved
Hide resolved
* Regenerated files and pulled changes to fix issue with incorrect Access Control cluster revision and enabled provisional ConfigurationVersion * Fixed persisting DevKitName attribute Signed-off-by: Kamil Kasperczyk <[email protected]>
3e68da5 to
ed47f2d
Compare