Migrate to nrfx 4.0 #478
Merged
Migrate to nrfx 4.0 #478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
manifest
changelog-entry-required
|
The following west manifest projects have changed revision in this Pull Request:
✅ All manifest checks OK Note: This message is automatically posted and updated by the Manifest GitHub Action. |
|
You can find the documentation preview for this PR here. |
anhmolt
force-pushed
the
update-to-nrfx-4.0
branch
from
04df66a to
e51cdec
Compare
anhmolt
force-pushed
the
update-to-nrfx-4.0
branch
3 times, most recently
from
fb3fad3 to
52b0f13
Compare
anhmolt
force-pushed
the
update-to-nrfx-4.0
branch
from
52b0f13 to
eb3e0ce
Compare
anhmolt
force-pushed
the
update-to-nrfx-4.0
branch
from
eb3e0ce to
a76f155
Compare
MirkoCovizzi
approved these changes
Nov 26, 2025
Contributor
MirkoCovizzi
left a comment
MirkoCovizzi
left a comment
There was a problem hiding this comment.
Gave a cursory look and it looks quite good to me.
| nrfx_uarte_t *uarte_inst; | ||
| /* Uarte instance configuration. */ | ||
| nrfx_uarte_config_t uarte_cfg; | ||
| /* gpiote instances. */ |
Contributor
There was a problem hiding this comment.
Nit: Gpiote instances. Same above.
Contributor
anhmolt
force-pushed
the
update-to-nrfx-4.0
branch
from
a76f155 to
a847011
Compare
Contributor
|
I'll align the NFC |
anhmolt
force-pushed
the
update-to-nrfx-4.0
branch
from
6e75236 to
d235bd7
Compare
Contributor
|
@anhmolt The PR nrfconnect/sdk-nrf#25376 is already merged |
anhmolt
force-pushed
the
update-to-nrfx-4.0
branch
from
d235bd7 to
ff8a0ac
Compare
Contributor
Author
Thanks. Updated sdk-nrf manifest revision to SHA. |
nordicjm
reviewed
Dec 1, 2025
subsys/nfc/lib/nfc_bm_platform.c
Outdated
| LOG_MODULE_REGISTER(nfc_platform, CONFIG_NFC_PLATFORM_LOG_LEVEL); | ||
|
|
||
| #if NRF54L_ERRATA_60_ENABLE_WORKAROUND | ||
| #define NFC_PLATFORM_USE_TIMER_WORKAROUND 1 |
Contributor
There was a problem hiding this comment.
we don't really indent #if
subsys/nfc/lib/nfc_bm_platform.c
Outdated
| #endif | ||
|
|
||
| #if NFC_PLATFORM_USE_TIMER_WORKAROUND | ||
| #define NFC_TIMER_IRQn NRFX_CONCAT_3(TIMER, \ |
Contributor
There was a problem hiding this comment.
the spacing here looks to be bit like a tab has been used, when a space would be fine?
anhmolt
force-pushed
the
update-to-nrfx-4.0
branch
from
ff8a0ac to
44133e0
Compare
ankuns
force-pushed
the
update-to-nrfx-4.0
branch
from
44133e0 to
24f5be4
Compare
Contributor
Author
|
Updated sdk-nrf revision in west.yml to v3.2.0-rc1. |
anhmolt
force-pushed
the
update-to-nrfx-4.0
branch
from
24f5be4 to
44133e0
Compare
Remove unused nrf.h header includes in preparation for nrfx 4.0. Signed-off-by: Andreas Moltumyr <[email protected]>
Update code to use nrfx 4.0. * Changed error returns from nrfx_error_t to errno. * Removed usage of NRFX_xxx_INST_HANDLER_GET. * Removed use of nrfx_uarte_rx (previously deprecated). * Macro NRFX_xxx_INSTANCE now expects the peripheral's base address instead of instance number. * Updated the nrf-bm specific hal_nordic Kconfig file. * Change name of clock power handler in irq_connect to avoid a name clash. * The nfc_platform.h API in sdk-nrfxlib changed. Align implementation of nfc_bm_platform.c to the required API changes. (The alignment is based on sdk-nrf PR # 25376 to the subsys/nfc/lib/platform.c) Additionally, the NFC_PLATFORM_USE_TIMER_WORKAROUND is provided when nrfx define NRF54L_ERRATA_60_ENABLE_WORKAROUND. Signed-off-by: Andreas Moltumyr <[email protected]> Signed-off-by: Andrzej Kuros <[email protected]>
anhmolt
force-pushed
the
update-to-nrfx-4.0
branch
from
44133e0 to
3b11dd9
Compare
Contributor
Author
|
rebased |
michalek-no
approved these changes
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes necessary for updating to nrfx 4.0.
https://github.com/NordicSemiconductor/nrfx/blob/v4.0.0/doc/nrfx_4_0_migration_guide.md