Security config #469
Security config #469
Conversation
github-actions
bot
added
changelog-entry-required
|
You can find the documentation preview for this PR here. |
eivindj-nordic
force-pushed
the
security_config
branch
4 times, most recently
from
20984b1 to
52f1745
Compare
|
|
eivindj-nordic
force-pushed
the
security_config
branch
from
52f1745 to
f21e1ca
Compare
github-actions
bot
removed
the
changelog-entry-required
eivindj-nordic
force-pushed
the
security_config
branch
from
f21e1ca to
a1a64c7
Compare
|
|
||
| * Updated to use errno instead of nrf_errors. | ||
|
|
||
| BLE Services |
There was a problem hiding this comment.
This should be 'Bluetooth LE' according to the brand guide but I can update this in the final release notes PR.
eivindj-nordic
force-pushed
the
security_config
branch
3 times, most recently
from
6f393b2 to
201da5d
Compare
lemrey
left a comment
lemrey
left a comment
There was a problem hiding this comment.
Looks good, a few comments.
One question, what do we want to call the configuration structures?
In some places they are called _config, in some other they are _cfg.
| * value. | ||
| */ | ||
| ble_gap_conn_sec_mode_t read; | ||
| } hid_info; |
There was a problem hiding this comment.
Elsewhere there is _char as postfix, but we could shorten if we wanted, e.g.
sec_mode.ctrl_point_char.read -> sec_mode.ctrl_point.read
There was a problem hiding this comment.
Reason for _char is that there is not only characteristic values in the security config, but also report references. Will add _char.
I think this is broader than this PR. For all services it is _config, unless I have missed somewhere. Name of instances might vary, though that would not break the API to update. Let's take it in a separate PR? I would say lets use _config for the struct itself, then cfg can be used for instances. |
eivindj-nordic
force-pushed
the
security_config
branch
2 times, most recently
from
120ae5f to
2db09fd
Compare
eivindj-nordic
force-pushed
the
security_config
branch
from
2db09fd to
6bf9c7b
Compare
eivindj-nordic
force-pushed
the
security_config
branch
from
6bf9c7b to
3ef0b4a
Compare
Update security configuration for CGMS service. Signed-off-by: Eivind Jølsgard <[email protected]>
Update security configuration for BAS service. Signed-off-by: Eivind Jølsgard <[email protected]>
Update security configuration for DIS service. HEeder celanup. Signed-off-by: Eivind Jølsgard <[email protected]>
Update security configuration for HIDS service. Signed-off-by: Eivind Jølsgard <[email protected]>
Update security configuration for HRS service. Signed-off-by: Eivind Jølsgard <[email protected]>
Update security configuration for LBS service. Signed-off-by: Eivind Jølsgard <[email protected]>
Update security configuration for MCUmgr service. Signed-off-by: Eivind Jølsgard <[email protected]>
Update security configuration for NUS service. Signed-off-by: Eivind Jølsgard <[email protected]>
eivindj-nordic
force-pushed
the
security_config
branch
from
3ef0b4a to
abe054a
Compare
Remove sec_mode Kconfig template. Signed-off-by: Eivind Jølsgard <[email protected]>
eivindj-nordic
force-pushed
the
security_config
branch
from
abe054a to
9961cf4
Compare
|
@nrfconnect/ncs-co-build-system @nrfconnect/ncs-eris Please review. |
8 participants
No description provided.