-
-
Notifications
You must be signed in to change notification settings - Fork 5
feat: allow ignore packages #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
9romise
wants to merge
6
commits into
main
Choose a base branch
from
ignore/vulnerability
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+181
−41
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
d7a65d8
feat: add `ignore.vulnerability`
9romise e0de95c
feat: allow ignoring vulnerabilities for specific package versions
9romise a0ee384
feat: allow ignore deprecation and replacement
9romise c8f65c8
feat: allow ignore by package name
9romise 11c1331
feat: allow ignore upgrade
9romise c85a43e
add configration scope
9romise File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,22 @@ | ||
| import type { ConfigurationTarget } from 'vscode' | ||
| import { extractorEntries } from '#extractors' | ||
| import { config } from '#state' | ||
| import { computed, watch } from 'reactive-vscode' | ||
| import { CodeActionKind, Disposable, languages } from 'vscode' | ||
| import { computed, useCommand, watch } from 'reactive-vscode' | ||
| import { CodeActionKind, Disposable, languages, workspace } from 'vscode' | ||
| import { scopedConfigs } from '../../generated-meta' | ||
| import { QuickFixProvider } from './quick-fix' | ||
|
|
||
| export function useCodeActions() { | ||
| const hasQuickFix = computed(() => config.diagnostics.upgrade || config.diagnostics.vulnerability) | ||
| useCommand('npmx.addToIgnore', async (scope: string, name: string, target: ConfigurationTarget) => { | ||
| scope = `ignore.${scope}` | ||
| const config = workspace.getConfiguration(scopedConfigs.scope) | ||
| const current = config.get<string[]>(scope, []) | ||
| if (current.includes(name)) | ||
| return | ||
| await config.update(scope, [...current, name], target) | ||
| }) | ||
|
Comment on lines
+10
to
+17
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Validate command arguments before mutating configuration.
Suggested patch useCommand('npmx.addToIgnore', async (scope: string, name: string, target: ConfigurationTarget) => {
+ if (!scope || !name)
+ return
+ if (!['deprecation', 'replacement', 'vulnerability'].includes(scope))
+ return
+
scope = `ignore.${scope}`
const config = workspace.getConfiguration(scopedConfigs.scope)
const current = config.get<string[]>(scope, [])
if (current.includes(name))
return
await config.update(scope, [...current, name], target)
}) |
||
|
|
||
| const hasQuickFix = computed(() => config.diagnostics.upgrade || config.diagnostics.deprecation || config.diagnostics.replacement || config.diagnostics.vulnerability) | ||
|
|
||
| watch(hasQuickFix, (enabled, _, onCleanup) => { | ||
| if (!enabled) | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.