fix: remove icon in anchor links in text#1765
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis change narrows two CSS selectors in Readme.vue so the hash-link pseudo-element (::after) and its hover rule now apply only to anchors that are children of heading elements (h1–h6) instead of all anchors with href starting with '#'. No HTML, JavaScript, or other styling changes were made. Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
🔗 Linked issue
Resolves #1762
📚 Description
We included a hash icon next to every anchor link in the text to indicate that it was an anchor link. We agreed in the Discord channel that we should remove it. We will keep the hash icons only for heading anchor links.