Skip to content

fix: remove icon in anchor links in text#1765

Merged
danielroe merged 2 commits intonpmx-dev:mainfrom
vmrjnvc:fix/remove-in-text-anchor-links-icon
Mar 1, 2026
Merged

fix: remove icon in anchor links in text#1765
danielroe merged 2 commits intonpmx-dev:mainfrom
vmrjnvc:fix/remove-in-text-anchor-links-icon

Conversation

@vmrjnvc
Copy link
Contributor

@vmrjnvc vmrjnvc commented Feb 28, 2026

🔗 Linked issue

Resolves #1762

📚 Description

We included a hash icon next to every anchor link in the text to indicate that it was an anchor link. We agreed in the Discord channel that we should remove it. We will keep the hash icons only for heading anchor links.

@vercel
Copy link

vercel bot commented Feb 28, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 28, 2026 9:08pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 28, 2026 9:08pm
npmx-lunaria Ignored Ignored Feb 28, 2026 9:08pm

Request Review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 28, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 47dc81b and 5acb664.

📒 Files selected for processing (1)
  • app/components/Readme.vue
🚧 Files skipped from review as they are similar to previous changes (1)
  • app/components/Readme.vue

📝 Walkthrough

Walkthrough

This change narrows two CSS selectors in Readme.vue so the hash-link pseudo-element (::after) and its hover rule now apply only to anchors that are children of heading elements (h1–h6) instead of all anchors with href starting with '#'. No HTML, JavaScript, or other styling changes were made.

Possibly related PRs

Suggested reviewers

  • danielroe
  • alexdln
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description clearly describes the changes: removing hash icons from in-text anchor links while keeping them only for heading anchor links, directly addressing issue #1762.
Linked Issues check ✅ Passed The code changes fully implement the requirements from issue #1762 by restricting the hash icon styling to heading-contained anchors only, removing it from all other in-text anchor links.
Out of Scope Changes check ✅ Passed All changes are directly scoped to the stated objective: modifying CSS selectors in Readme.vue to restrict hash icon display to heading anchors only, with no extraneous modifications.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Feb 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@danielroe danielroe added this pull request to the merge queue Mar 1, 2026
Merged via the queue into npmx-dev:main with commit 3a5d256 Mar 1, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Anchor icons on links in body text

2 participants