fix(i18n): update zh-CN translations & localize error page#1755
fix(i18n): update zh-CN translations & localize error page#1755danielroe merged 3 commits intonpmx-dev:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
📝 WalkthroughWalkthroughAdds new i18n entries and schema properties for HTTP error messages and two chart UI labels. app/error.vue now reads status and statusText from the incoming error prop and uses translated messages for 401, 404, 500, 503 and a default fallback. Two components (TrendsChart.vue and VersionDistribution.vue) add Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
app/error.vue (1)
29-31: Minor:useHeadtitle may not update reactively.Passing
status.valueandstatusText.valuedirectly evaluates them once. If the error were ever to change, the title would not update. For an error page this is typically acceptable, but for full reactivity consider wrapping in a getter:useHead({ title: () => `${status.value} - ${statusText.value}`, })
graphieros
left a comment
There was a problem hiding this comment.
✅ Changes made in the chart configuration are ok
🔗 Linked issue
🧭 Context
📚 Description
401、404、500、503anddefaulti18n keys to error pagezh-CNTranslations (profile page)