Skip to content

fix(a11y): limit route announcer noise on search#1754

Open
taskylizard wants to merge 1 commit intonpmx-dev:mainfrom
taskylizard:feat/1751-route-announcer
Open

fix(a11y): limit route announcer noise on search#1754
taskylizard wants to merge 1 commit intonpmx-dev:mainfrom
taskylizard:feat/1751-route-announcer

Conversation

@taskylizard
Copy link
Contributor

fixes #1751

@vercel
Copy link

vercel bot commented Feb 28, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 28, 2026 4:18pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 28, 2026 4:18pm
npmx-lunaria Ignored Ignored Feb 28, 2026 4:18pm

Request Review

@codecov
Copy link

codecov bot commented Feb 28, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
app/app.vue 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 28, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e5ccbff and 2586a40.

📒 Files selected for processing (1)
  • app/app.vue

📝 Walkthrough

Walkthrough

The change adds a NuxtRouteAnnouncer component to App.vue that handles route change announcements through a scoped slot. The component conditionally renders different text based on the active route: for the search route, it outputs a translated package title followed by " - npmx", whilst for all other routes it renders the standard route announcement message. This introduces accessibility-focused route change notifications via Nuxt's built-in announcer component.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description references issue #1751, which directly relates to adding NuxtRouteAnnouncer functionality shown in the changeset.
Linked Issues check ✅ Passed The code changes implement the NuxtRouteAnnouncer with custom logic that announces initial search route navigation while suppressing noise from subsequent result updates.
Out of Scope Changes check ✅ Passed The changes are limited to App.vue and directly address the stated objective of adding NuxtRouteAnnouncer with controlled announcement behaviour.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add NuxtRouteAnnouncer to announce route changes

1 participant