Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
ba20524 to
e403cdd
Compare
…mx.dev into fix/image-proxy-logic
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdds an ISR route rule for Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Great job, thank you, @alexdln ! What about scarf tracking pixel? I guess that many OSS projects are using this service? |
|
I mean I am not sure that it would work through proxy if we do not whitelist it |
|
Okay. I do not have experience to evaluate if it's ethically correct to block other OSS project's analytics. |
|
By opening direct requests, we're not only opening for a counter, but also directly transmitting the IP address and other info. If they're really only interested in the number, they'll get it. If they're interested in detailed user information, I don't think it's more ethical to let them do that |

🔗 Linked issue
Resolves #1743
🧭 Context
Badges and images were not displayed in a large number of packages.
📚 Description
Passing queries to this API route wasn't allowed - added a setting to nuxt.config
Many popular badges weren't added to the list - added them.
SVG proxying was prohibited, but since we don't embed it in the DOM anywhere - allowed its use