Fix wrong assert when using --omap igncr, n=0 is valid value#121
Open
jlnbotello wants to merge 1 commit intonpat-efault:masterfrom
Open
Fix wrong assert when using --omap igncr, n=0 is valid value#121jlnbotello wants to merge 1 commit intonpat-efault:masterfrom
jlnbotello wants to merge 1 commit intonpat-efault:masterfrom
Conversation
|
Looks like this is a duplicate of https://github.com/npat-efault/picocom/pull/114/files#diff-20d639d96366c45f2f9be53f52c722b64bb22ee79eed9637caa5f763027b833dL820 Definitely seems like a bug as I see |
|
Yes, it is a duplicate of #114. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On CR mapping (line 766) n=0 for igncr option. So the final assert (line 820) on do_map function should not fail.