Update knex #3
Open
Update knex #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| declare class Knex$Knex mixins Knex$QueryBuilder, Promise, events$EventEmitter { | ||
| static (config: Knex$Config): Knex$Knex, | ||
| declare class Knex$Knex<T> mixins Knex$QueryBuilder<T>, Promise, events$EventEmitter { | ||
| static (config: Knex$Config): Knex$Knex<T>, |
There was a problem hiding this comment.
Wow, this all seems very tricky. There are at least a couple things I think we need to consider:
- We don't want to over-constrain the type parameter of
Knex$Knex, since we'd like it to represent the whole database, which could contain many tables (yelp-gil-service's db is an outlier with only 1 table). - Joins seem especially tricky, since they are a single operation, e.g.
innerJointhat involves at least 2 types--one for each table involved in the join. They may even involve 3 types--one for each table, plus one for the result type if the two tables are joined in a projection (i.e. a subset of fields from each table). Sometimes that 3rd type might be a proper intersection of the two other types, but not always.
I have some ideas, but nothing concrete yet ... let's talk about it tomorrow if we have time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.