fix(docs): render nested objects in payloads and responses#29
Open
p-fernandez wants to merge 1 commit intomainfrom
Open
fix(docs): render nested objects in payloads and responses#29p-fernandez wants to merge 1 commit intomainfrom
p-fernandez wants to merge 1 commit intomainfrom
Conversation
❌ Deploy Preview for novu-api-docs failed.
|
p-fernandez
commented
Feb 1, 2023
|
|
||
| await novu.subscribers.updatePreference(user.id, templateId, { | ||
| channel: { | ||
| type: 'fcm', |
Contributor
Author
There was a problem hiding this comment.
This channel doesn't exist.
p-fernandez
force-pushed
the
fix-render-nested-objects
branch
from
c9f0c5b to
9d2155d
Compare
✅ api-docs deploy preview ready
|
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Render nested objects in payloads and responses and tidy up code.
Not fully rendering the objects in the payloads are causing confusion in our users that read the documentation and the API docs. This should help them.
Unfortunately has been very hard to keep proper alignment in the rendering of the template literals. 🙁
BEFORE
AFTER
