test: allow half-open CONNECT tunnel sockets - #64973
Merged
trivikr merged 1 commit intoAug 10, 2026
Merged
Conversation
nodejs-github-bot
added
needs-ci
Member
Author
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64973 +/- ##
=======================================
Coverage 90.33% 90.33%
=======================================
Files 760 760
Lines 248523 248523
Branches 46904 46911 +7
=======================================
Hits 224505 224505
+ Misses 15460 15454 -6
- Partials 8558 8564 +6 🚀 New features to boost your workflow:
|
lpinca
approved these changes
Aug 4, 2026
github-actions
Bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
trivikr
added
author ready
avivkeller
added
commit-queue-failed
Member
Commit Queue failed- Loading data for nodejs/node/pull/64973 ✔ Done loading data for nodejs/node/pull/64973 ----------------------------------- PR info ------------------------------------ Title test: allow half-open CONNECT tunnel sockets (#64973) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch trivikr:flaky-test-https-proxy-request-invalid-char-in-url -> nodejs:main Labels test, author ready, needs-ci, commit-queue Commits 1 - test: allow half-open CONNECT tunnel sockets Committers 1 - Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> PR-URL: https://github.com/nodejs/node/pull/64973 Refs: https://github.com/nodejs/reliability/issues?q=%22test-https-proxy-request-invalid-char-in-url%22 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/64973 Refs: https://github.com/nodejs/reliability/issues?q=%22test-https-proxy-request-invalid-char-in-url%22 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 03 Aug 2026 06:00:06 GMT ✔ Approvals: 1 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/64973#pullrequestreview-4858130222 ✘ This PR needs to wait 8 more hours to land (or 0 minutes if there is one more approval) ✔ Last GitHub CI successful ℹ Last Full PR CI on 2026-08-06T05:55:30Z: https://ci.nodejs.org/job/node-test-pull-request/75553/ - Querying data for job/node-test-pull-request/75553/ ✔ Build data downloaded ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /Users/avivkeller/Documents/projects/nodejs/node/.ncu/nodejs/node/actions/runs/ |
avivkeller
added
commit-queue
CONNECT tunnels are full-duplex. When the upstream socket receives a FIN while the client-to-upstream pipe is still draining, the default socket behavior can produce EPIPE or ECONNRESET errors. Keep the upstream socket half-open so both directions can drain. Separate request logs from transport errors to verify that teardown completes without errors. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: codex:gpt-5.6-sol PR-URL: nodejs#64973 Refs: https://github.com/nodejs/reliability/issues?q=%22test-https-proxy-request-invalid-char-in-url%22 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
trivikr
force-pushed
the
flaky-test-https-proxy-request-invalid-char-in-url
branch
from
August 10, 2026 06:19
a83ef4f to
780229b
Compare
Member
Author
|
Landed in 780229b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: https://github.com/nodejs/reliability/issues?q=%22test-https-proxy-request-invalid-char-in-url%22
CONNECT tunnels are full-duplex. When the upstream socket receives a FIN while the client-to-upstream pipe is still draining, the default socket behavior can produce EPIPE or ECONNRESET errors.
Keep the upstream socket half-open so both directions can drain. Separate request logs from transport errors to verify that teardown completes without errors.
Assisted-by: codex:gpt-5.6-sol