sqlite: isolate applyChangeset filter errors - #64823
Merged
Merged
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
trivikr
force-pushed
the
sqlite-filter-exception-supression
branch
from
July 29, 2026 16:18
58e98fa to
927eaf5
Compare
louwers
approved these changes
Jul 29, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #64823 +/- ##
==========================================
+ Coverage 90.32% 90.33% +0.01%
==========================================
Files 760 760
Lines 248523 248523
Branches 46896 46904 +8
==========================================
+ Hits 224469 224505 +36
+ Misses 15465 15460 -5
+ Partials 8589 8558 -31
🚀 New features to boost your workflow:
|
trivikr
force-pushed
the
sqlite-filter-exception-supression
branch
from
August 2, 2026 14:15
927eaf5 to
bf13e4c
Compare
trivikr
force-pushed
the
sqlite-filter-exception-supression
branch
from
August 9, 2026 23:32
bf13e4c to
6fec5e8
Compare
Qard
approved these changes
Aug 10, 2026
trivikr
added
the
author ready
github-actions
Bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
Track filter callback failures within each applyChangeset() invocation. Returning false from xFilter is not a SQLite error. This previously left the database-wide suppression flag set, which could hide the next unrelated SQLite error. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: codex:gpt-5.6-sol PR-URL: nodejs#64823 Fixes: nodejs#64822 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
trivikr
force-pushed
the
sqlite-filter-exception-supression
branch
from
August 10, 2026 06:04
6fec5e8 to
ab95309
Compare
Member
Author
|
Landed in ab95309 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #64822
When an
applyChangeset()filter callback throws,ignore_next_sqlite_error_is set. Returning false fromxFilteris notitself a SQLite error, so
sqlite3changeset_apply()can returnSQLITE_OKwithout consuming the flag. The next unrelated SQLite error is then
silently suppressed.
This change keeps filter callback failure state local to the
applyChangeset()invocation.Assisted-by: codex:gpt-5.6-sol