tools: update cpplint to v2.0.2 #60901

targos · 2025-11-30T07:44:16Z

nodejs-github-bot · 2025-11-30T07:44:21Z

Review requested:

@nodejs/crypto
@nodejs/inspector
@nodejs/node-api

targos · 2025-11-30T07:50:46Z

deps/ncrypto/ncrypto.h:69: Controlled statements inside brackets of if clause should be on a separate line [whitespace/newline] [5]

Saw that locally too. I'm surprised to see a lint error in deps.

aduh95 · 2025-11-30T07:57:25Z

I'm surprised to see a lint error in deps.

See #55362

codecov · 2025-11-30T09:06:17Z

Codecov Report

❌ Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.55%. Comparing base (768f3ba) to head (81819f0).
⚠️ Report is 21 commits behind head on main.

Files with missing lines	Patch %	Lines
src/quic/session.cc	0.00%	2 Missing ⚠️
src/crypto/crypto_util.cc	50.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #60901      +/-   ##
==========================================
- Coverage   88.56%   88.55%   -0.01%     
==========================================
  Files         703      703              
  Lines      208291   208293       +2     
  Branches    40169    40170       +1     
==========================================
- Hits       184472   184463       -9     
- Misses      15831    15841      +10     
- Partials     7988     7989       +1

Files with missing lines	Coverage Δ
src/env.cc	`85.15% <ø> (-0.47%)`	⬇️
src/inspector_socket.cc	`83.21% <ø> (ø)`
src/crypto/crypto_util.cc	`72.08% <50.00%> (+0.07%)`	⬆️
src/quic/session.cc	`29.07% <0.00%> (-0.03%)`	⬇️

... and 26 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Disable linting where there are false positives or clashes whith the C++ formatter.

Cherry-pick 12c8b4d Original commit message: This commit is a suggestion for adding a rule for NULL usages in the code base. This will currently report a number of errors which could be ignored using // NOLINT (readability/null_usage) PR-URL: nodejs#17373 Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Refs: nodejs@12c8b4d Cherry-pick fc81e80 Original commit message: Update cpplint.py to check for inline headers when the corresponding header is already included. PR-URL: nodejs#21521 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Refs: nodejs@fc81e80 Cherry-pick cbc3dd9 Original commit message: src, tools: add check for left leaning pointers This commit adds a rule to cpplint to check that pointers in the code base lean to the left and not right, and also fixes the violations reported. PR-URL: nodejs#21010 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Refs: nodejs@cbc3dd9 Cherry-pick 9029981 Original commit message: tools: fix cpplint.py header rules THIS COMMIT SHOULD GO WITH THE NEXT. IT WILL FIND NEW LINT. PR-URL: nodejs#26306 Reviewed-By: Gireesh Punathil <[email protected]> Refs: nodejs@9029981 Cherry-pick 0a25ace Original commit message: tools: move cpplint configuration to .cpplint PR-URL: nodejs#27098 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Refs: nodejs@0a25ace Cherry-pick afa9a72 Original commit message: tools: refloat update link to google styleguide for cpplint This commit updates two old links to Google's C++ styleguide which currently result in a 404 when accessed. PR-URL: nodejs#30876 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]> Refs: nodejs@afa9a72 Cherry-pick e23bf8f Original commit message: tools,src: refloat forbid usage of v8::Persistent `v8::Persistent` comes with the surprising catch that it requires manual cleanup. `v8::Global` doesn’t, making it easier to use, and additionally provides move semantics. New code should always use `v8::Global`. PR-URL: nodejs#31018 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Backport 3d954dc Original commit message: tools: remove readability/fn_size rule PR-URL: nodejs#54663 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Refs: nodejs@3d954dc Cherry-pick c7d7ec7 Original commit message: tools: check for std::vector<v8::Local> in lint PR-URL: nodejs#58497 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Refs: nodejs@c7d7ec7 Cherry-pick e6d94ef Original commit message: tools: add C++ lint rule to avoid using `String::Utf8Value` We should be using our own helpers for this instead. PR-URL: nodejs#60244 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Edy Silva <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ilyas Shabi <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Vladimir Morozov <[email protected]> Refs: nodejs@e6d94ef

nodejs-github-bot · 2025-11-30T19:24:06Z

CI: https://ci.nodejs.org/job/node-test-pull-request/70357/

nodejs-github-bot · 2025-12-01T10:17:22Z

CI: https://ci.nodejs.org/job/node-test-pull-request/70361/

nodejs-github-bot · 2025-12-01T13:34:59Z

CI: https://ci.nodejs.org/job/node-test-pull-request/70364/

nodejs-github-bot · 2025-12-02T07:51:43Z

Commit Queue failed

- Loading data for nodejs/node/pull/60901
✔  Done loading data for nodejs/node/pull/60901
----------------------------------- PR info ------------------------------------
Title      tools: update cpplint to v2.0.2 (#60901)
Author     Michaël Zasso <[email protected]> (@targos)
Branch     targos:cpplint-v2 -> nodejs:main
Labels     c++, lib / src, author ready, needs-ci
Commits    4
 - deps,src: prepare for cpplint update
 - tools: disable some new cpplint rules before update
 - tools: update cpplint to 2.0.2
 - tools: refloat 10 Node.js patches to cpplint.py
Committers 1
 - Michaël Zasso <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/60901
Fixes: https://github.com/nodejs/node/issues/60771
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Vladimir Morozov <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/60901
Fixes: https://github.com/nodejs/node/issues/60771
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Vladimir Morozov <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 30 Nov 2025 07:44:16 GMT
   ✔  Approvals: 2
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/60901#pullrequestreview-3522115201
   ✔  - Vladimir Morozov (@vmoroz): https://github.com/nodejs/node/pull/60901#pullrequestreview-3522242621
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2025-12-01T13:34:59Z: https://ci.nodejs.org/job/node-test-pull-request/70364/
- Querying data for job/node-test-pull-request/70364/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 60901
From https://github.com/nodejs/node
 * branch                  refs/pull/60901/merge -> FETCH_HEAD
✔  Fetched commits as 85852a3221b1..81819f098ef7
--------------------------------------------------------------------------------
[main 5e42e58627] deps,src: prepare for cpplint update
 Author: Michaël Zasso <[email protected]>
 Date: Wed Nov 26 18:05:35 2025 +0100
 6 files changed, 16 insertions(+), 3 deletions(-)
[main 1bd101e9e2] tools: disable some new cpplint rules before update
 Author: Michaël Zasso <[email protected]>
 Date: Sun Nov 30 08:42:11 2025 +0100
 1 file changed, 1 insertion(+), 1 deletion(-)
[main 234a61dfab] tools: update cpplint to 2.0.2
 Author: Michaël Zasso <[email protected]>
 Date: Sun Nov 23 16:06:08 2025 +0100
 1 file changed, 7006 insertions(+), 6194 deletions(-)
[main 2d3a7575c4] tools: refloat 10 Node.js patches to cpplint.py
 Author: Michaël Zasso <[email protected]>
 Date: Wed Nov 26 17:37:05 2025 +0100
 1 file changed, 148 insertions(+), 9 deletions(-)
   ✔  Patches applied
There are 4 commits in the PR. Attempting autorebase.
(node:2217) [DEP0190] DeprecationWarning: Passing args to a child process with shell option true can lead to security vulnerabilities, as the arguments are not escaped, only concatenated.
(Use `node --trace-deprecation ...` to show where the warning was created)
Rebasing (2/8)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
deps,src: prepare for cpplint update
Disable linting where there are false positives or clashes whith the C++

formatter.
PR-URL: #60901

Fixes: #60771

Reviewed-By: Luigi Pinca <[email protected]>

Reviewed-By: Vladimir Morozov <[email protected]>
[detached HEAD 51260bd603] deps,src: prepare for cpplint update

Author: Michaël Zasso <[email protected]>

Date: Wed Nov 26 18:05:35 2025 +0100

6 files changed, 16 insertions(+), 3 deletions(-)

Rebasing (3/8)

Rebasing (4/8)

Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

tools: disable some new cpplint rules before update
PR-URL: #60901

Fixes: #60771

Reviewed-By: Luigi Pinca <[email protected]>

Reviewed-By: Vladimir Morozov <[email protected]>
[detached HEAD 4667648e56] tools: disable some new cpplint rules before update

Author: Michaël Zasso <[email protected]>

Date: Sun Nov 30 08:42:11 2025 +0100

1 file changed, 1 insertion(+), 1 deletion(-)

Rebasing (5/8)

Rebasing (6/8)

Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

tools: update cpplint to 2.0.2
PR-URL: #60901

Fixes: #60771

Reviewed-By: Luigi Pinca <[email protected]>

Reviewed-By: Vladimir Morozov <[email protected]>
[detached HEAD bf18800103] tools: update cpplint to 2.0.2

Author: Michaël Zasso <[email protected]>

Date: Sun Nov 23 16:06:08 2025 +0100

1 file changed, 7006 insertions(+), 6194 deletions(-)

Rebasing (7/8)

Rebasing (8/8)

Executing: git node land --amend --yes

⚠  Found Reviewed-By: Luigi Pinca <[email protected]>, skipping..

⚠  Found Reviewed-By: Vladimir Morozov <[email protected]>, skipping..

--------------------------------- New Message ----------------------------------

tools: refloat 10 Node.js patches to cpplint.py
Cherry-pick 12c8b4d15471cb6211b39c3a2ca5b10fa4b9f12b

Original commit message:

This commit is a suggestion for adding a rule for NULL usages in the

code base. This will currently report a number of errors which could be

ignored using // NOLINT (readability/null_usage)
PR-URL: https://github.com/nodejs/node/pull/17373
Reviewed-By: Jon Moss &lt;[email protected]&gt;
Reviewed-By: Anna Henningsen &lt;[email protected]&gt;
Reviewed-By: Timothy Gu &lt;[email protected]&gt;
Reviewed-By: Colin Ihrig &lt;[email protected]&gt;
Reviewed-By: Michael Dawson &lt;[email protected]&gt;
Reviewed-By: Sakthipriyan Vairamani &lt;[email protected]&gt;
Reviewed-By: Tobias Nießen &lt;[email protected]&gt;

Refs: 12c8b4d
Cherry-pick fc81e801913de3e3f3c0c8e26c105f983a74e539

Original commit message:
Update cpplint.py to check for inline headers when the corresponding
header is already included.

PR-URL: https://github.com/nodejs/node/pull/21521
Reviewed-By: Ben Noordhuis &lt;[email protected]&gt;
Reviewed-By: James M Snell &lt;[email protected]&gt;

Refs: fc81e80
Cherry-pick cbc3dd997eb90d629d1b9912b7a5a40eb82343df

Original commit message:
src, tools: add check for left leaning pointers

This commit adds a rule to cpplint to check that pointers in the code
base lean to the left and not right, and also fixes the violations
reported.

PR-URL: https://github.com/nodejs/node/pull/21010
Reviewed-By: Ben Noordhuis &lt;[email protected]&gt;
Reviewed-By: Anna Henningsen &lt;[email protected]&gt;
Reviewed-By: Ruben Bridgewater &lt;[email protected]&gt;
Reviewed-By: James M Snell &lt;[email protected]&gt;

Refs: cbc3dd9
Cherry-pick 902998190a55d6915b881936f6dd5b6e9cca6ad8

Original commit message:
tools: fix cpplint.py header rules

THIS COMMIT SHOULD GO WITH THE NEXT. IT WILL FIND NEW LINT.

PR-URL: https://github.com/nodejs/node/pull/26306
Reviewed-By: Gireesh Punathil &lt;[email protected]&gt;

Refs: 9029981
Cherry-pick 0a25ace9c35b62ece4d32fd90b326d8063265109

Original commit message:
tools: move cpplint configuration to .cpplint

PR-URL: https://github.com/nodejs/node/pull/27098
Reviewed-By: Joyee Cheung &lt;[email protected]&gt;
Reviewed-By: Daniel Bevenius &lt;[email protected]&gt;

Refs: 0a25ace
Cherry-pick afa9a7206c26a29a2af226696c145c924a6d3754

Original commit message:
tools: refloat update link to google styleguide for cpplint

This commit updates two old links to Google's C++ styleguide which
currently result in a 404 when accessed.

PR-URL: https://github.com/nodejs/node/pull/30876
Reviewed-By: Michaël Zasso &lt;[email protected]&gt;
Reviewed-By: David Carlier &lt;[email protected]&gt;
Reviewed-By: Colin Ihrig &lt;[email protected]&gt;
Reviewed-By: Richard Lau &lt;[email protected]&gt;
Reviewed-By: Rich Trott &lt;[email protected]&gt;

Refs: afa9a72
Cherry-pick e23bf8f771aa0bd60e25ff079985fc29b5846403

Original commit message:
tools,src: refloat forbid usage of v8::Persistent

`v8::Persistent` comes with the surprising catch that it requires
manual cleanup. `v8::Global` doesn’t, making it easier to use,
and additionally provides move semantics. New code should always
use `v8::Global`.

PR-URL: https://github.com/nodejs/node/pull/31018
Reviewed-By: Colin Ihrig &lt;[email protected]&gt;
Reviewed-By: Richard Lau &lt;[email protected]&gt;
Reviewed-By: James M Snell &lt;[email protected]&gt;
Reviewed-By: David Carlier &lt;[email protected]&gt;
Reviewed-By: Rich Trott &lt;[email protected]&gt;
Reviewed-By: Gus Caplan &lt;[email protected]&gt;
Reviewed-By: Joyee Cheung &lt;[email protected]&gt;
Reviewed-By: Ben Noordhuis &lt;[email protected]&gt;
Reviewed-By: Stephen Belanger &lt;[email protected]&gt;

Backport 3d954dcf812bb500a77913ffd5ebec76235714f0

Original commit message:
tools: remove readability/fn_size rule

PR-URL: https://github.com/nodejs/node/pull/54663
Reviewed-By: Yagiz Nizipli &lt;[email protected]&gt;
Reviewed-By: Luigi Pinca &lt;[email protected]&gt;

Refs: 3d954dc
Cherry-pick c7d7ec7cda56b7776797cbdef3d4497fc98e8440

Original commit message:
tools: check for std::vector&lt;v8::Local&gt; in lint

PR-URL: https://github.com/nodejs/node/pull/58497
Reviewed-By: James M Snell &lt;[email protected]&gt;
Reviewed-By: Juan José Arboleda &lt;[email protected]&gt;
Reviewed-By: Joyee Cheung &lt;[email protected]&gt;

Refs: c7d7ec7
Cherry-pick e6d94ef106e08999e5461dabfeb333ff141f59fe

Original commit message:
tools: add C++ lint rule to avoid using `String::Utf8Value`

We should be using our own helpers for this instead.

PR-URL: https://github.com/nodejs/node/pull/60244
Reviewed-By: Chengzhong Wu &lt;[email protected]&gt;
Reviewed-By: Rafael Gonzaga &lt;[email protected]&gt;
Reviewed-By: Edy Silva &lt;[email protected]&gt;
Reviewed-By: Colin Ihrig &lt;[email protected]&gt;
Reviewed-By: Ilyas Shabi &lt;[email protected]&gt;
Reviewed-By: Yagiz Nizipli &lt;[email protected]&gt;
Reviewed-By: Vladimir Morozov &lt;[email protected]&gt;

Refs: e6d94ef

PR-URL: #60901

Fixes: #60771
[detached HEAD a78bcd1b59] tools: refloat 10 Node.js patches to cpplint.py

Author: Michaël Zasso <[email protected]>

Date: Wed Nov 26 17:37:05 2025 +0100

1 file changed, 148 insertions(+), 9 deletions(-)

Successfully rebased and updated refs/heads/main.
ℹ  Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/19851137564

nodejs-github-bot · 2025-12-02T08:03:28Z

Landed in 85852a3...8cfcf52

Disable linting where there are false positives or clashes whith the C++ formatter. PR-URL: #60901 Fixes: #60771 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Vladimir Morozov <[email protected]>

PR-URL: #60901 Fixes: #60771 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Vladimir Morozov <[email protected]>

Cherry-pick 12c8b4d Original commit message: This commit is a suggestion for adding a rule for NULL usages in the code base. This will currently report a number of errors which could be ignored using // NOLINT (readability/null_usage) PR-URL: #17373 Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Refs: 12c8b4d Cherry-pick fc81e80 Original commit message: Update cpplint.py to check for inline headers when the corresponding header is already included. PR-URL: #21521 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Refs: fc81e80 Cherry-pick cbc3dd9 Original commit message: src, tools: add check for left leaning pointers This commit adds a rule to cpplint to check that pointers in the code base lean to the left and not right, and also fixes the violations reported. PR-URL: #21010 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Refs: cbc3dd9 Cherry-pick 9029981 Original commit message: tools: fix cpplint.py header rules THIS COMMIT SHOULD GO WITH THE NEXT. IT WILL FIND NEW LINT. PR-URL: #26306 Reviewed-By: Gireesh Punathil <[email protected]> Refs: 9029981 Cherry-pick 0a25ace Original commit message: tools: move cpplint configuration to .cpplint PR-URL: #27098 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Refs: 0a25ace Cherry-pick afa9a72 Original commit message: tools: refloat update link to google styleguide for cpplint This commit updates two old links to Google's C++ styleguide which currently result in a 404 when accessed. PR-URL: #30876 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]> Refs: afa9a72 Cherry-pick e23bf8f Original commit message: tools,src: refloat forbid usage of v8::Persistent `v8::Persistent` comes with the surprising catch that it requires manual cleanup. `v8::Global` doesn’t, making it easier to use, and additionally provides move semantics. New code should always use `v8::Global`. PR-URL: #31018 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Backport 3d954dc Original commit message: tools: remove readability/fn_size rule PR-URL: #54663 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Refs: 3d954dc Cherry-pick c7d7ec7 Original commit message: tools: check for std::vector<v8::Local> in lint PR-URL: #58497 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Refs: c7d7ec7 Cherry-pick e6d94ef Original commit message: tools: add C++ lint rule to avoid using `String::Utf8Value` We should be using our own helpers for this instead. PR-URL: #60244 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Edy Silva <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ilyas Shabi <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Vladimir Morozov <[email protected]> Refs: e6d94ef PR-URL: #60901 Fixes: #60771

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Nov 30, 2025

targos added 4 commits November 30, 2025 10:13

deps,src: prepare for cpplint update

a879031

Disable linting where there are false positives or clashes whith the C++ formatter.

tools: disable some new cpplint rules before update

d71dade

tools: update cpplint to 2.0.2

3fa9675

targos force-pushed the cpplint-v2 branch from 90f4369 to 81819f0 Compare November 30, 2025 09:14

lpinca approved these changes Nov 30, 2025

View reviewed changes

lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 30, 2025

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 30, 2025

vmoroz approved these changes Nov 30, 2025

View reviewed changes

aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 1, 2025

aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 1, 2025

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Dec 2, 2025

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 2, 2025

nodejs-github-bot pushed a commit that referenced this pull request Dec 2, 2025

tools: disable some new cpplint rules before update

fc85c7a

PR-URL: #60901 Fixes: #60771 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Vladimir Morozov <[email protected]>

nodejs-github-bot closed this Dec 2, 2025

nodejs-github-bot pushed a commit that referenced this pull request Dec 2, 2025

tools: update cpplint to 2.0.2

11813f9

PR-URL: #60901 Fixes: #60771 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Vladimir Morozov <[email protected]>

targos deleted the cpplint-v2 branch December 2, 2025 08:04

Uh oh!

tools: update cpplint to v2.0.2 #60901

tools: update cpplint to v2.0.2 #60901

Uh oh!

Conversation

targos commented Nov 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Nov 30, 2025

Uh oh!

targos commented Nov 30, 2025

Uh oh!

aduh95 commented Nov 30, 2025

Uh oh!

codecov bot commented Nov 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

nodejs-github-bot commented Nov 30, 2025

Uh oh!

nodejs-github-bot commented Dec 1, 2025

Uh oh!

nodejs-github-bot commented Dec 1, 2025

Uh oh!

nodejs-github-bot commented Dec 2, 2025

PR-URL: #60901 Fixes: #60771 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Vladimir Morozov <[email protected]>

PR-URL: #60901 Fixes: #60771 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Vladimir Morozov <[email protected]>

PR-URL: #60901 Fixes: #60771 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Vladimir Morozov <[email protected]>

Refs: e6d94ef PR-URL: #60901 Fixes: #60771

[detached HEAD a78bcd1b59] tools: refloat 10 Node.js patches to cpplint.py Author: Michaël Zasso <[email protected]> Date: Wed Nov 26 17:37:05 2025 +0100 1 file changed, 148 insertions(+), 9 deletions(-) Successfully rebased and updated refs/heads/main.

Uh oh!

nodejs-github-bot commented Dec 2, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

targos commented Nov 30, 2025 •

edited

Loading

codecov bot commented Nov 30, 2025 •

edited

Loading

PR-URL: #60901
Fixes: #60771
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Vladimir Morozov <[email protected]>

PR-URL: #60901
Fixes: #60771
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Vladimir Morozov <[email protected]>

PR-URL: #60901
Fixes: #60771
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Vladimir Morozov <[email protected]>

Refs: `e6d94ef`
PR-URL: #60901
Fixes: #60771

[detached HEAD a78bcd1b59] tools: refloat 10 Node.js patches to cpplint.py
Author: Michaël Zasso <[email protected]>
Date: Wed Nov 26 17:37:05 2025 +0100
1 file changed, 148 insertions(+), 9 deletions(-)
Successfully rebased and updated refs/heads/main.