Skip to content

Conversation

Xiao-Tao
Copy link
Contributor

issue:#60258
LoongArch64 CI is in a failed state (https://ci.nodejs.org/job/node-test-commit-loongarch64/nodes=clfs23-64/)

"'CODETYPE' was not declared in this scope" appears when compiling after upgrading V8 to 14.1

13:25:59   loongarch64-unknown-linux-gnu-g++ -o /home/iojs/build/workspace/node-test-commit-loongarch64/out/Release/obj.target/v8_initializers/gen/torque-generated/src/builtins/array-reduce-tq-csa.o /home/iojs/build/workspace/node-test-commit-loongarch64/out/Release/obj/gen/torque-generated/src/builtins/array-reduce-tq-csa.cc '-D_GLIBCXX_USE_CXX11_ABI=1' '-D_FILE_OFFSET_BITS=64' '-DNODE_OPENSSL_CONF_NAME=nodejs_conf' '-DICU_NO_USER_DATA_OVERRIDE' '-DV8_GYP_BUILD' '-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=64' '-D__STDC_FORMAT_MACROS' '-DOPENSSL_NO_PINSHARED' '-DOPENSSL_THREADS' '-DOPENSSL_NO_ASM' '-DV8_TARGET_ARCH_LOONG64' '-DV8_HAVE_TARGET_OS' '-DV8_TARGET_OS_LINUX' '-DV8_EMBEDDER_STRING="-node.10"' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT=1' '-DV8_ENABLE_PRIVATE_MAPPING_FORK_OPTIMIZATION' '-DOBJECT_PRINT' '-DV8_INTL_SUPPORT' '-DV8_ATOMIC_OBJECT_FIELD_WRITES' '-DV8_ENABLE_LAZY_SOURCE_POSITIONS' '-DV8_USE_SIPHASH' '-DNDEBUG' '-DV8_WIN64_UNWINDING_INFO' '-DV8_ENABLE_REGEXP_INTERPRETER_THREADED_DISPATCH' '-DV8_USE_ZLIB' '-DV8_ENABLE_LEAPTIERING' '-DV8_ENABLE_SPARKPLUG' '-DV8_ENABLE_TURBOFAN' '-DV8_ENABLE_WEBASSEMBLY' '-DV8_ENABLE_JAVASCRIPT_PROMISE_HOOKS' '-DV8_ENABLE_CONTINUATION_PRESERVED_EMBEDDER_DATA' '-DV8_ALLOCATION_FOLDING' '-DV8_ALLOCATION_SITE_TRACKING' '-DV8_ADVANCED_BIGINT_ALGORITHMS' '-DUCONFIG_NO_SERVICE=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=1' '-DUCONFIG_NO_BREAK_ITERATION=0' -I../deps/v8 -I../deps/v8/include -I/home/iojs/build/workspace/node-test-commit-loongarch64/out/Release/obj/gen -I/home/iojs/build/workspace/node-test-commit-loongarch64/out/Release/obj/gen/generate-bytecode-output-root -I../deps/v8/third_party/fp16/src/include -I../deps/v8/third_party/abseil-cpp -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common  -pthread -Wno-unused-parameter -Wno-strict-overflow -Wno-return-type -Wno-int-in-bool-context -Wno-deprecated -Wno-stringop-overflow -Wno-stringop-overread -Wno-restrict -Wno-array-bounds -Wno-nonnull -Wno-dangling-pointer -flax-vector-conversions -O3 -fno-omit-frame-pointer -fdata-sections -ffunction-sections -O3 -fno-rtti -fno-exceptions -fno-strict-aliasing -std=gnu++20 -Wno-invalid-offsetof -MMD -MF /home/iojs/build/workspace/node-test-commit-loongarch64/out/Release/.deps//home/iojs/build/workspace/node-test-commit-loongarch64/out/Release/obj.target/v8_initializers/gen/torque-generated/src/builtins/array-reduce-tq-csa.o.d.raw   -c
13:25:59 ../deps/v8/src/builtins/loong64/builtins-loong64.cc: In function ‘void v8::internal::GetSharedFunctionInfoBytecodeOrBaseline(MacroAssembler*, Register, Register, Register, Label*, Label*)’:
13:25:59 ../deps/v8/src/builtins/loong64/builtins-loong64.cc:331:54: 错误:‘CODETYPE’ was not declared in this scope; did you mean ‘CODE_TYPE’?
13:26:02   331 |       __ Branch(&not_baseline, ne, scratch1, Operand(CODETYPE));
13:26:04       |                                                      ^~~~~~~~
13:26:04       |                                                      CODE_TYPE

Origin commit message:

[loong64] Fix no pointer compression build

1. Fix a typo that breaks no static root build.
2. Use less scratch regs in some compare and branch functions.

This bug is triggered by Node.js loong64 port.

Change-Id: If251906cc07feca237c75f0b65517526085f61dd
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7031299
Reviewed-by: Leszek Swirski <[email protected]>
Auto-Submit: Zhao Jiazhong <[email protected]>
Commit-Queue: Zhao Jiazhong <[email protected]>
Cr-Commit-Position: refs/heads/main@{#103105}

Refs: v8/v8@7ef6a00

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/security-wg
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Oct 15, 2025
@targos
Copy link
Member

targos commented Oct 15, 2025

Please increment the embedder string

Origin commit message:

    [loong64] Fix no pointer compression build

    1. Fix a typo that breaks no static root build.
    2. Use less scratch regs in some compare and branch functions.

    This bug is triggered by Node.js loong64 port.

    Change-Id: If251906cc07feca237c75f0b65517526085f61dd
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7031299
    Reviewed-by: Leszek Swirski <[email protected]>
    Auto-Submit: Zhao Jiazhong <[email protected]>
    Commit-Queue: Zhao Jiazhong <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#103105}

Refs: v8/v8@7ef6a00
@Xiao-Tao Xiao-Tao force-pushed the fix-loong64-CODETYPE branch from 0500136 to edd2c59 Compare October 15, 2025 06:52
@targos targos added dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. loong64 Issues and PRs related to the loong64 architecture. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Oct 15, 2025
@Xiao-Tao
Copy link
Contributor Author

@targos Thank you for the guidance!
I have increased the v8_embedder_string count

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. loong64 Issues and PRs related to the loong64 architecture. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants