Skip to content

typings: correct internal bindings for worker, http_parser, config #60257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

typings: correct internal bindings for worker, http_parser, config #60257

wants to merge 3 commits into from
+11 −1

Conversation

whsung0330
Copy link
Contributor

worker.d.ts:

  • Worker/WorkerBinding: Add missing bindings for hasRef(), threadName, and isInternalThread.

http_parser.d.ts:

  • HTTPParser: Add missing instance method remove() and several related kLenient... constants (7 items).

config.d.ts:

  • ConfigBinding: Remove the hasDtrace property as it is not present in the current node_config.cc implementation

@atlowChemi atlowChemi added commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonrig anonrig anonrig approved these changes

@cjihrig cjihrig cjihrig approved these changes

@atlowChemi atlowChemi atlowChemi approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. typings

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@whsung0330 @anonrig @cjihrig @atlowChemi @nodejs-github-bot