test: skip sea tests on x64 macOS #60250
Conversation
nodejs-github-bot
added
needs-ci
There was a problem hiding this comment.
Can you also migrate
node/test/sequential/sequential.status
Lines 74 to 93 in 59b70e5
sequential.status to the new sea.status?
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60250 +/- ##
==========================================
+ Coverage 88.53% 88.56% +0.02%
==========================================
Files 704 704
Lines 208087 208322 +235
Branches 40010 40037 +27
==========================================
+ Hits 184239 184500 +261
+ Misses 15866 15863 -3
+ Partials 7982 7959 -23 🚀 New features to boost your workflow:
|
joyeecheung
force-pushed
the
skip-macos-64
branch
2 times, most recently
from
425d75f to
4d84244
Compare
|
Added the missing Linux PPC64 skips and fixed the linter complaints (seems to be only activated on the touched files). Can you take another look? Thanks @richardlau |
This comment was marked as outdated.
This comment was marked as outdated.
|
Not sure where this linter comes from, but it's not correct: |
|
Oh right, it's the codeowner file that needs to be updated..updating |
This comment was marked as outdated.
This comment was marked as outdated.
joyeecheung
force-pushed
the
skip-macos-64
branch
from
4d84244 to
f14e663
Compare
github-actions
bot
added
request-ci-failed
This comment was marked as outdated.
This comment was marked as outdated.
richardlau
added
request-ci
github-actions
bot
removed
the
request-ci
richardlau
added
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/60250 ✔ Done loading data for nodejs/node/pull/60250 ----------------------------------- PR info ------------------------------------ Title test: skip sea tests on x64 macOS (#60250) Author Joyee Cheung <[email protected]> (@joyeecheung) Branch joyeecheung:skip-macos-64 -> nodejs:main Labels test, needs-ci, commit-queue-rebase Commits 2 - test: move sea tests into test/sea - test: skip sea tests on x64 macOS Committers 1 - Joyee Cheung <[email protected]> PR-URL: https://github.com/nodejs/node/pull/60250 Refs: https://github.com/nodejs/node/issues/59553 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ulises Gascón <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Darshan Sen <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/60250 Refs: https://github.com/nodejs/node/issues/59553 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ulises Gascón <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Darshan Sen <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 13 Oct 2025 20:58:14 GMT ✔ Approvals: 4 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/60250#pullrequestreview-3339971328 ✔ - Ulises Gascón (@UlisesGascon): https://github.com/nodejs/node/pull/60250#pullrequestreview-3340288264 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/60250#pullrequestreview-3342814703 ✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/60250#pullrequestreview-3343476785 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2025-10-15T23:21:32Z: https://ci.nodejs.org/job/node-test-pull-request/69751/ - Querying data for job/node-test-pull-request/69751/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 60250 From https://github.com/nodejs/node * branch refs/pull/60250/merge -> FETCH_HEAD ✔ Fetched commits as 71f5b1cbf054..f14e663c3ab1 -------------------------------------------------------------------------------- [main c22cc8aad3] test: move sea tests into test/sea Author: Joyee Cheung <[email protected]> Date: Mon Oct 13 22:42:22 2025 +0200 24 files changed, 105 insertions(+), 107 deletions(-) create mode 100644 test/sea/sea.status rename test/{sequential => sea}/test-single-executable-application-asset-keys-empty.js (97%) rename test/{sequential => sea}/test-single-executable-application-asset-keys.js (98%) rename test/{sequential => sea}/test-single-executable-application-assets-raw.js (98%) rename test/{sequential => sea}/test-single-executable-application-assets.js (96%) rename test/{sequential => sea}/test-single-executable-application-disable-experimental-sea-warning.js (97%) rename test/{sequential => sea}/test-single-executable-application-empty.js (99%) rename test/{sequential => sea}/test-single-executable-application-exec-argv-empty.js (96%) rename test/{sequential => sea}/test-single-executable-application-exec-argv-extension-cli.js (96%) rename test/{sequential => sea}/test-single-executable-application-exec-argv-extension-env.js (98%) rename test/{sequential => sea}/test-single-executable-application-exec-argv-extension-none.js (96%) rename test/{sequential => sea}/test-single-executable-application-exec-argv.js (99%) rename test/{sequential => sea}/test-single-executable-application-inspect-in-sea-flags.js (98%) rename test/{sequential => sea}/test-single-executable-application-inspect.js (99%) rename test/{sequential => sea}/test-single-executable-application-snapshot-and-code-cache.js (98%) rename test/{sequential => sea}/test-single-executable-application-snapshot-worker.js (97%) rename test/{sequential => sea}/test-single-executable-application-snapshot.js (95%) rename test/{sequential => sea}/test-single-executable-application-use-code-cache.js (97%) rename test/{sequential => sea}/test-single-executable-application.js (97%) rename test/{parallel => sea}/test-single-executable-blob-config-errors.js (90%) rename test/{parallel => sea}/test-single-executable-blob-config.js (99%) create mode 100644 test/sea/testcfg.py [main 46a1ded0e2] test: skip sea tests on x64 macOS Author: Joyee Cheung <[email protected]> Date: Mon Oct 13 22:57:48 2025 +0200 1 file changed, 1 insertion(+), 19 deletions(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4) Executing: git node land --amend --yes --------------------------------- New Message ---------------------------------- test: move sea tests into test/seahttps://github.com/nodejs/node/actions/runs/18579155019 |
This makes skipping/running these tests easier to manage with a dedicated test runner that can be tweaked for SEA. PR-URL: nodejs#60250 Refs: nodejs#59553 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ulises Gascón <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
It's unlikely that anyone would invest in fixing them on x64 macOS in the near future, now that x64 macOS is being phased out. Simply skip them for now. PR-URL: nodejs#60250 Refs: nodejs#59553 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ulises Gascón <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
joyeecheung
force-pushed
the
skip-macos-64
branch
from
f14e663 to
9e8c753
Compare
|
Fixed the commit message line length and landed manually in c2f3c21...9e8c753 |
6 participants
test: move sea tests into test/sea
This makes skipping/running these tests easier to manage with a
dedicated test runner that can be tweaked for SEA.
test: skip sea tests on x64 macOS
It's unlikely that anyone would invest in fixing them on x64 macOS in the
near future, now that x64 macOS is being phased out. Simply skip them
for now.
Refs: #59553