fix: handle removed IdleNotificationDeadline
#999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
codebytere
force-pushed
the
IdleNotificationDeadline
branch
2 times, most recently
from
31573b0 to
760eb1a
Compare
|
Thabk you. Looks good at a glance. I shall take a closer look soon when I have a chance.
…On May 20, 2025 11:10:00 AM GMT+03:00, Shelley Vohr ***@***.***> wrote:
See https://chromium-review.googlesource.com/c/v8/v8/+/5539852 - this has been removed upstream and will no longer build on newer V8 versions.
You can view, comment on, or merge this pull request online at:
#999
-- Commit Summary --
* fix: handle removed IdleNotificationDeadline
-- File Changes --
M nan.h (7)
-- Patch Links --
https://github.com/nodejs/nan/pull/999.patch
https://github.com/nodejs/nan/pull/999.diff
--
Reply to this email directly or view it on GitHub:
#999
You are receiving this because you are subscribed to this thread.
Message ID: ***@***.***>
|
|
Could you explain why this is needed now? V8 11.something is already older than the 12.7 when it was removed. Is that when the deprecation warning was introduced? |
codebytere
force-pushed
the
IdleNotificationDeadline
branch
from
760eb1a to
cbbbd6c
Compare
|
@kkoopa yes - i based the numbers off #953 (comment) which is where the notice was introduced. I changed it to 12.7. Sorry for the delay here! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://chromium-review.googlesource.com/c/v8/v8/+/5539852 - this has been removed upstream and will no longer build on newer V8 versions.