Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/logger/__tests__/logger.test.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,8 @@ describe('createLogger', () => {

const logger = createLogger(transport, LogLevel.error);

logger.error(new Error('Hello, World!'));
const error = new Error('Hello, World!');
logger.error(error);

strictEqual(transport.mock.callCount(), 1);

Expand All @@ -212,7 +213,9 @@ describe('createLogger', () => {
{
level: LogLevel.error,
message: 'Hello, World!',
metadata: {},
metadata: {
stack: error.stack,
},
module: undefined,
timestamp: 0,
},
Expand Down
8 changes: 7 additions & 1 deletion src/logger/logger.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,13 @@ export const createLogger = (
const timestamp = Date.now();

// Extract message string from Error object or use message as-is
const msg = message instanceof Error ? message.message : message;
let msg;
if (message instanceof Error) {
msg = message.message;
metadata.stack = message.stack;
} else {
msg = message;
}

transport({
level,
Expand Down
6 changes: 5 additions & 1 deletion src/logger/transports/console.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import { prettifyTimestamp } from '../utils/time.mjs';
* @returns {void}
*/
const console = ({ level, message, timestamp, metadata = {}, module }) => {
const { file } = metadata;
const { file, stack } = metadata;

const time = prettifyTimestamp(timestamp);

Expand All @@ -37,6 +37,10 @@ const console = ({ level, message, timestamp, metadata = {}, module }) => {
}

process.stdout.write('\n');

if (stack) {
process.stdout.write(stack);
}
};

export default console;
2 changes: 2 additions & 0 deletions src/logger/types.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ export interface File {

interface Metadata {
file?: File;
// Stack trace if the message is an error
stack?: string;
}

interface TransportContext {
Expand Down
Loading