Skip to content

Conversation

@knolleary
Copy link
Member

Alternative fix to #73 - rather than stub it, expose the real internal plugin api.

@knolleary
Copy link
Member Author

Initial testing suggests more is needed. Parking for now - will merge/release with #73 to unblock some other work that is happening and come back to this another day.

@joepavitt
Copy link

Just tried this locally, and this._RED.plugins is undefined in the index.js

@joepavitt
Copy link

Mentioned that it should have been this._RED.runtime.plugins

Even with this, we then see different behaviour to core:

Test Helper:

RED.plugins.getByType('node-red-dashboard-2') returns Promise { [ ] }

Node-RED Core:

RED.plugins.getByType('node-red-dashboard-2') returns []

@knolleary
Copy link
Member Author

@joepavitt that is odd. Can't see anything async in either code path that would result in a promise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants