Add Rotate and Zoom as drag effects - #1862
Open
miguelAngelo1999 wants to merge 2 commits into
Open
Conversation
…a buttons Fixes noah-nuebling#1791, noah-nuebling#1790, noah-nuebling#1800, noah-nuebling#1740, noah-nuebling#1744 Logitech mice with extra buttons (thumb, tilt wheel, precision, side buttons) use HID++ 2.0 ReprogControlsV4 (feature 0x1B04). These buttons are silently consumed by the mouse firmware until the host sends a SetCidReporting command to divert them. Once diverted, they arrive as 0x11 long reports. This implementation calls Buttons.handleInput() directly — no CGEvent round-trip needed, no extra event tap overhead. Protocol: - GetFeature(0x1B04) -> feature index - GetCount -> number of controls on this device - GetCidInfo for each control -> CID, TID, capability flags - Skip controls whose TID maps to a native HID button (L/R/M/Back/Fwd) - SetCidReporting with flags=0x03 (divert=1, divert_valid=1) for the rest The flags byte follows the 'valid bit' pattern documented in Solaar (pwr-Solaar/Solaar hidpp20.py): each flag bit has a corresponding valid bit = flag << 1, telling firmware the field is being intentionally set. TID-based filtering correctly excludes natively-reported buttons across all Logitech models without any per-device hardcoding. Tested on: Logitech M720 Triathlon (Bluetooth), macOS 15 Sequoia, macOS 26 - Left tilt (CID=0x005B) -> button 6 in MMF ✅ - Right tilt (CID=0x005D) -> button 7 in MMF ✅ - Thumb (CID=0x00D0) -> button 8 in MMF ✅ - Back/forward continue working natively (not diverted) ✅ References: - https://github.com/pwr-Solaar/Solaar (hidpp20.py) - https://github.com/libratbag/libratbag (hidpp20.c) - https://lekensteyn.nl/files/logitech/x1b04_specialkeysmsebuttons.html
Hold button + move mouse to rotate or zoom: - Rotate: horizontal movement → rotation (like twisting 2 fingers on trackpad) - Zoom: vertical movement → magnification (like pinching on trackpad) Uses TouchSimulator postRotationEventWithRotation/postMagnificationEventWithMagnification. Proper phase handling (Began/Changed/Ended/Cancelled).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds rotate and zoom as drag output plugins — hold a button and move the mouse to rotate or zoom.
Uses existing TouchSimulator methods with proper phase handling (Began/Changed/Ended/Cancelled).
New files: ModifiedDragOutputRotateZoom.h/.m